Closed Bug 1241648 Opened 4 years ago Closed 4 years ago
mozscreenshots: Fix path to screenshot executables on Windows/Linux
MozReview Request: Bug 1241648 - mozscreenshots: Support also looking for screenshot executables in ../bin/ like the usual utilityPath. r=ahal
58 bytes, text/x-review-board-request
Looking in GreBinD only works for local builds it seems. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=26636e4b1c31
Local builds put the utilities in GreBinD but mozharness puts them in tests/bin (specified by --utility-path) which isn't easily readable by the application. Review commit: https://reviewboard.mozilla.org/r/31837/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/31837/
Attachment #8710697 - Flags: review?(ahalberstadt)
I'm basically hardcoding "../bin" since it doesn't seem like there is a way to know the utilityPath from within Firefox and it seems like the path is unlikely to change on desktop. I did kinda wonder why we don't just add the utilityPath to the OS PATH env. variable. We could also pass it with a custom variable if this patch is too fragile.
Comment on attachment 8710697 [details] MozReview Request: Bug 1241648 - mozscreenshots: Support also looking for screenshot executables in ../bin/ like the usual utilityPath. r=ahal This looks good to me, but I've never heard of this file until now, so not sure I should be r+'ing it. Blame looks useless, not sure who owns this.
Attachment #8710697 - Flags: review?(ahalberstadt) → feedback+
(In reply to Andrew Halberstadt [:ahal] from comment #3) > This looks good to me, but I've never heard of this file until now, so not > sure I should be r+'ing it. Since I'm a browser peer I can delegate review to non-browser peers so you could r+ if you are comfortable. I'm mostly asking you because of the mozharness integration. > Blame looks useless, not sure who owns this. I just landed this the other day and it's tool I've been working on for a while, it's just finally landing in-tree and getting hooked up to automation.
[bugday-20160323] Status: RESOLVED,FIXED -> VERIFIED Comments: Test Successful Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Attribute accepted no warning given Actual Results: As expected
3 years ago
Component: General → mozscreenshots
Product: Firefox → Testing
Target Milestone: Firefox 46 → ---
You need to log in before you can comment on or make changes to this bug.