MacIOSurfaceTextureSourceBasic needs to handle video formats

RESOLVED FIXED in Firefox 45

Status

()

Core
Graphics: Layers
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed, firefox46 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
MacIOSurfaceTextureSourceBasic::GetSurface calls MacIOSurface::GetAsSurface which doesn't handle video formats and creates bad surfaces.
(Assignee)

Comment 1

2 years ago
Created attachment 8710721 [details]
MozReview Request: Bug 1241665 - Move IOSurface YCbCr conversion code to a new file MacIOSurfaceHelpers.cpp. r?mattwoodrow

Ideally this would live in gfx/2d/MacIOSurface.cpp, but we don't have access to the
YCbCr conversion utilities in Moz2D.

Review commit: https://reviewboard.mozilla.org/r/31847/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31847/
Attachment #8710721 - Flags: review?(matt.woodrow)
(Assignee)

Comment 2

2 years ago
Created attachment 8710722 [details]
MozReview Request: Bug 1241665 - Correctly convert IOSurfaces to SourceSurfaces in MacIOSurfaceTextureSourceBasic and MacIOSurfaceTextureData. r?mattwoodrow

Review commit: https://reviewboard.mozilla.org/r/31849/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31849/
Attachment #8710722 - Flags: review?(matt.woodrow)
Comment on attachment 8710721 [details]
MozReview Request: Bug 1241665 - Move IOSurface YCbCr conversion code to a new file MacIOSurfaceHelpers.cpp. r?mattwoodrow

https://reviewboard.mozilla.org/r/31847/#review28577
Attachment #8710721 - Flags: review?(matt.woodrow) → review+
Attachment #8710722 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8710722 [details]
MozReview Request: Bug 1241665 - Correctly convert IOSurfaces to SourceSurfaces in MacIOSurfaceTextureSourceBasic and MacIOSurfaceTextureData. r?mattwoodrow

https://reviewboard.mozilla.org/r/31849/#review28581
Blocks: 1187322

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b07035a777bb
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e0f1024dbc9
status-firefox45: --- → affected

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b07035a777bb
https://hg.mozilla.org/mozilla-central/rev/2e0f1024dbc9
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Markus, we need this patch to be uplifted to 45 to be able to land bug 1187322? Could you take care of the uplift request? Thanks
Flags: needinfo?(mstange)
(Assignee)

Comment 8

2 years ago
Comment on attachment 8710721 [details]
MozReview Request: Bug 1241665 - Move IOSurface YCbCr conversion code to a new file MacIOSurfaceHelpers.cpp. r?mattwoodrow

Approval Request Comment
[Feature/regressing bug #]: BasicCompositor on OS X
[User impact if declined]: crashes and no video when hardware acceleration is off
[Describe test coverage new/current, TreeHerder]: none (we don't run any tests with hardware acceleration disabled on OS X)
[Risks and why]: very low, just makes us use proven conversion code in more places
[String/UUID change made/needed]: none
Flags: needinfo?(mstange)
Attachment #8710721 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

2 years ago
Attachment #8710722 - Flags: approval-mozilla-aurora?
Comment on attachment 8710721 [details]
MozReview Request: Bug 1241665 - Move IOSurface YCbCr conversion code to a new file MacIOSurfaceHelpers.cpp. r?mattwoodrow

That was fast, thanks!
Taking it as it fixes crashes.
Attachment #8710721 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8710722 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 10

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/cb7ae108000d
https://hg.mozilla.org/releases/mozilla-aurora/rev/bbf2df5dba13
status-firefox45: affected → fixed
You need to log in before you can comment on or make changes to this bug.