Add telemetry probe to measure how often users restore bookmarks while connected to Sync

RESOLVED FIXED in Firefox 51

Status

()

P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ckarlof, Assigned: tcsc)

Tracking

(Blocks: 2 bugs)

unspecified
Firefox 51
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [data-integrity])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Hopefully this may provide some insight into how to prioritize bug 1230011.
(Reporter)

Updated

3 years ago
Flags: firefox-backlog+
Priority: -- → P2
(Assignee)

Comment 1

3 years ago
Created attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

Review commit: https://reviewboard.mozilla.org/r/49329/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49329/
Attachment #8746240 - Flags: review?(markh)
(Assignee)

Updated

3 years ago
Assignee: nobody → tchiovoloni
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

Added a new telemetry probe to Histograms.json
Attachment #8746240 - Flags: review?(benjamin)
Blocks: 1263835
Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

https://reviewboard.mozilla.org/r/49329/#review47131

I don't think this helps us answer the question asked in bug 1230011 - I suspect we want a boolean histogram with the value recording whether the .wipeServer() call succeeded or not.
Attachment #8746240 - Flags: review?(markh)
Attachment #8746240 - Flags: review?(benjamin)
Whiteboard: [sync-data-integrity]
Whiteboard: [sync-data-integrity] → [data-integrity]
(Assignee)

Comment 4

3 years ago
Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49329/diff/1-2/
Attachment #8746240 - Attachment description: MozReview Request: Bug 1241699 - Add a telemetry probe measuring how frequently a bookmark restore occurs while sync is active r?markh → Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate f?markh
Attachment #8746240 - Flags: review?(markh)
(Assignee)

Comment 5

3 years ago
Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

Something more like this?
Attachment #8746240 - Flags: review?(markh) → feedback?(markh)
https://reviewboard.mozilla.org/r/49329/#review61162

Now we have the sync ping, I wonder if we should just arrange for this to be in that ping?
(Assignee)

Comment 7

3 years ago
https://reviewboard.mozilla.org/r/49329/#review61162

Maybe, although it's not clear to me where in the ping it would go. It does seem reasonably well suited for being a histogram, and I don't *think* we'd want more detailed visualizations than are available for the histograms, but I could be wrong, maybe being able to correlate this with other errors would be valuable...
Attachment #8746240 - Flags: review+
Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

https://reviewboard.mozilla.org/r/49329/#review62416

Yeah, I agree a histogram is the best solution here.
Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

This patch adds a new histogram to measure how often a user restores their bookmarks while connected to Sync, but when Sync is unable to delete the server copy of the bookmarks, which will cause bad things to happen.

It is set to expire in 55, and the sync team will monitor the probe to decide how to prioritize mitigating this situation.
Attachment #8746240 - Flags: feedback?(markh) → review?(benjamin)
Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

https://reviewboard.mozilla.org/r/49329/#review66130
Attachment #8746240 - Flags: review?(benjamin) → review+
(Assignee)

Comment 11

3 years ago
Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49329/diff/2-3/
Attachment #8746240 - Attachment description: Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate f?markh → Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 12

3 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/47d39d542c7d
Add a telemetry probe measuring sync storage server wipe succeess rate. r=markh r=bsmedberg
Keywords: checkin-needed

Comment 13

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/47d39d542c7d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.