1241699 - Add telemetry probe to measure how often users restore bookmarks while connected to Sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Chris Karlof [:ckarlof]]

Hopefully this may provide some insight into how to prioritize bug 1230011.

Comment 1

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

Review commit: https://reviewboard.mozilla.org/r/49329/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49329/

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

Added a new telemetry probe to Histograms.json

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

https://reviewboard.mozilla.org/r/49329/#review47131

I don't think this helps us answer the question asked in bug 1230011 - I suspect we want a boolean histogram with the value recording whether the .wipeServer() call succeeded or not.

Comment 4

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49329/diff/1-2/

Comment 5

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

Something more like this?

Comment 6

[Mark Hammond [:markh] [:mhammond]]

https://reviewboard.mozilla.org/r/49329/#review61162

Now we have the sync ping, I wonder if we should just arrange for this to be in that ping?

Comment 7

[Thom Chiovoloni [:tcsc] (ex-moco)]

https://reviewboard.mozilla.org/r/49329/#review61162

Maybe, although it's not clear to me where in the ping it would go. It does seem reasonably well suited for being a histogram, and I don't *think* we'd want more detailed visualizations than are available for the histograms, but I could be wrong, maybe being able to correlate this with other errors would be valuable...

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

https://reviewboard.mozilla.org/r/49329/#review62416

Yeah, I agree a histogram is the best solution here.

Comment 9

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

This patch adds a new histogram to measure how often a user restores their bookmarks while connected to Sync, but when Sync is unable to delete the server copy of the bookmarks, which will cause bad things to happen.

It is set to expire in 55, and the sync team will monitor the probe to decide how to prioritize mitigating this situation.

Comment 10

[Benjamin Smedberg]

Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

https://reviewboard.mozilla.org/r/49329/#review66130

Comment 11

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8746240 [details]
Bug 1241699 - Add a telemetry probe measuring sync storage server wipe succeess rate

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49329/diff/2-3/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/47d39d542c7d
Add a telemetry probe measuring sync storage server wipe succeess rate. r=markh r=bsmedberg

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/47d39d542c7d