1241724 - Not right to judge for very early versions

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[YF (Yang)]

Start bisection for 2005-01-01 to 2006-01-01, the pack downloaded and started, but the tool prompt:
---------------------------
Launcher Error
---------------------------
An error occured while starting the process, so the build will be skipped. Error message:<br><strong>Application not found at: c:\users\yf\appdata\local\temp\tmph47ta6\firefox</strong>
---------------------------
OK   
---------------------------

Click the OK will close the started program, and auto skipped for it.


In addition, the "Dialog" ("Your build was skipped!") is no title, no icon, and cannot be closed by close window button, it re-popup always, you have to click then OK, then stop.

Comment 1

[Julien Pagès (:parkouss)]

Hm, the root cause probably comes from mozversion, https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozversion/mozversion/errors.py#20. I'll look into it.

Comment 2

[Julien Pagès (:parkouss)]

It is failing here: https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozversion/mozversion/mozversion.py#103

Because there is no convenient .ini file - I believe because those builds are really old. So correct behavior from mozversion I think (though the error name is weird).

So this should be fixed from the mozregression side. The other thing that need to be fixed is the skip dialog.

Comment 3

[Julien Pagès (:parkouss)]

Attachment: fixes

This fixes all the issues. Mozregression can't build a pushlog url for really older builds (in 2005), but those are really old and win32 only - but it won't crash, and the skip dialog is fixed (title, icon and ability to close it).

Comment 4

[MikeLing]

Comment on attachment 8716196 [details] [review]
fixes

Oh，it looks great! Not only for the skip dialog, I found we can also choose date from a date chooser. That's awesome :)

Comment 5

[Julien Pagès (:parkouss)]

Thanks Mike!

Merged in https://github.com/mozilla/mozregression/commit/a4c7aeda490644931a16edc586be4b11d253c25a.