1241752 - Remove runtime warning for nsIContent::GetEditingHost()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Calling nsIContent::GetEditingHost() [1] on a non-editable content generates the warning "WARNING: NS_ENSURE_TRUE(IsEditableInternal())". This generates a log of warning when I drag AccessibleCaret on same non-editable content on debug build.

I think returning null editing host for a non-editable is a normal failing case, which does not need a warning.

[1] https://dxr.mozilla.org/mozilla-central/source/dom/base/FragmentOrElement.cpp#242

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: MozReview Request: Bug 1241752 - Remove runtime warning for nsIContent::GetEditingHost(). r?smaug

Returning a null editing host for a non-editable is a normal failing case,
which does not need a warning.

Review commit: https://reviewboard.mozilla.org/r/31893/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31893/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8710873 [details]
MozReview Request: Bug 1241752 - Remove runtime warning for nsIContent::GetEditingHost(). r?smaug

https://reviewboard.mozilla.org/r/31893/#review28793

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3dbbccd71c06

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3dbbccd71c06