Closed Bug 1241780 Opened 8 years ago Closed 8 years ago

bluetooth panel modulization

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(1 file)

[gaia] gasolin:issue-1241780 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yzen
: review+
scottwu
: review+
Details | Review 
modulize panel related code (html, js, css) in `settings/views/phone/bluetooth`
Blocks: 1241778
Assignee: nobody → gasolin
Comment on attachment 8710902 [details] [review]
[gaia] gasolin:issue-1241780 > mozilla-b2g:master

We'd start panel modularization proposal described in bug 1241778, which will put panel related resources into single folder (instead of separate resources in /elements, js/panels, style/).

test fine on real device.
Attachment #8710902 - Flags: review?(yzenevich)
Attachment #8710902 - Flags: review?(scwwu)
Comment on attachment 8710902 [details] [review]
[gaia] gasolin:issue-1241780 > mozilla-b2g:master

Looks good thanks, Fred
Attachment #8710902 - Flags: review?(yzenevich) → review+
Comment on attachment 8710902 [details] [review]
[gaia] gasolin:issue-1241780 > mozilla-b2g:master

Tests good on my device too. Thanks Fred :)
r+
Attachment #8710902 - Flags: review?(scwwu) → review+
merged https://github.com/mozilla-b2g/gaia/commit/a5cb34517d8f89cc653b578eb6815616026725ed

thanks!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: