Closed Bug 1241916 Opened 4 years ago Closed 4 years ago

[gn] Add gn locale to browser/locales/shipped-locales for Fx45


(Firefox Build System :: General, defect)

45 Branch
Not set


(firefox45 fixed, firefox46 fixed)

Tracking Status
firefox45 --- fixed
firefox46 --- fixed


(Reporter: gueroJeff, Assigned: gueroJeff)




(1 file)

The Guaraní (gn) locale is ready to be added to shipped-locales for Aurora and Beta. The attached patch adds the locale for Aurora, but we'd like this to also be ported to Beta. Also, please do not reset all-locales and shipped-locales during merge day. As usual, this is not going to land on mozilla-central, as the l10n config there is just for nightly.

As I do not have commit access, this patch will need to be commited for me please.
Attachment #8711028 - Flags: review?(l10n)
Attachment #8711028 - Flags: approval-mozilla-aurora?
Blocks: fx-l10n-gn
Attachment #8711028 - Flags: review?(l10n) → review?(lebedel.delphine)
Comment on attachment 8711028 [details] [diff] [review]

Looks good to me. r+
Attachment #8711028 - Flags: review?(lebedel.delphine) → review+
Hey Ryan,

I need to get this patch landed before merge day. Could you take a look at it for me please for mozilla-aurora landing permission? The questions didn't pop up for me when I flagged it. The risk here is low, especially as long as we do not reset all-locales and shipped-locales during merge day.

Flags: needinfo?(ryanvm)
Release Management handles approvals, not me.
Flags: needinfo?(ryanvm) → needinfo?(sledru)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> Release Management handles approvals, not me.

Thank you. Sorry for the confusion.
Comment on attachment 8711028 [details] [diff] [review]

Flags: needinfo?(sledru)
Attachment #8711028 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Thank you. Can we make sure this gets landed and ported to Beta today so we get Beta builds for this locale out as early as possible please?
Whiteboard: checkin-needed-aurora
Attachment #8711028 - Attachment is patch: true
Attachment #8711028 - Attachment mime type: text/x-patch → text/plain
Blocks: 1242563
Landed on Aurora46 as well.
Assignee: nobody → jbeatty
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: checkin-needed-aurora
Thanks all!
This broke the build
2016-01-27 01:28:34,686 : INFO : Comparing l10n changesets on dashboard to on-disk buildbot-configs/mozilla/l10n-changesets_mozilla-beta ...
2016-01-27 01:28:35,331 : INFO : Comparing l10n changesets to shipped locales ...
2016-01-27 01:28:35,332 : ERROR : l10n_changesets and shipped_locales differ on locales: ['gn']
2016-01-27 01:28:35,332 : ERROR : Error verifying l10n_changesets matches shipped_locales

l10n.m.o didn't provide the l10n changeset for this locale. I went on
and used  2b9bb3cc4e54 as changeset
Can we land this again? Should I approve a changeset sign-off before it lands?
Flags: needinfo?(sledru)
Yes, we can. 
Please sign off when you can. Thanks!
Flags: needinfo?(sledru)
Awesome! I signed off on revision 9846a32f9c8f.
Is there anything more we need to do? Can we land this again before Beta 2 please?
Flags: needinfo?(cbook)
sylvestre is this ok to land now ?
Flags: needinfo?(cbook) → needinfo?(sledru)
Grabbing that needinfo from Sylvestre, as I have the data.

Yes, this is good to land now, and should land before the GTB for Beta 2.

Flagging back the needinfo for landing, lacking a better idea of how to flag my intent.
Flags: needinfo?(sledru) → needinfo?(cbook)
Flags: needinfo?(cbook)


STR: Not clear.
Developer specific testing

Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 45 → mozilla45
You need to log in before you can comment on or make changes to this bug.