Closed Bug 1241916 Opened 4 years ago Closed 4 years ago
[gn] Add gn locale to browser/locales/shipped-locales for Fx45
The Guaraní (gn) locale is ready to be added to shipped-locales for Aurora and Beta. The attached patch adds the locale for Aurora, but we'd like this to also be ported to Beta. Also, please do not reset all-locales and shipped-locales during merge day. As usual, this is not going to land on mozilla-central, as the l10n config there is just for nightly. As I do not have commit access, this patch will need to be commited for me please.
Attachment #8711028 - Flags: review?(l10n) → review?(lebedel.delphine)
Comment on attachment 8711028 [details] [diff] [review] add-gn-shipped-locales.patch Looks good to me. r+
Attachment #8711028 - Flags: review?(lebedel.delphine) → review+
Hey Ryan, I need to get this patch landed before merge day. Could you take a look at it for me please for mozilla-aurora landing permission? The questions didn't pop up for me when I flagged it. The risk here is low, especially as long as we do not reset all-locales and shipped-locales during merge day. Thanks, Jeff
Release Management handles approvals, not me.
Flags: needinfo?(ryanvm) → needinfo?(sledru)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #3) > Release Management handles approvals, not me. Thank you. Sorry for the confusion.
Comment on attachment 8711028 [details] [diff] [review] add-gn-shipped-locales.patch Sure
Attachment #8711028 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Thank you. Can we make sure this gets landed and ported to Beta today so we get Beta builds for this locale out as early as possible please?
Landed on Aurora46 as well. https://hg.mozilla.org/releases/mozilla-aurora/rev/302ab550a227
This broke the build 2016-01-27 01:28:34,686 : INFO : Comparing l10n changesets on dashboard https://l10n.mozilla.org/shipping/l10n-changesets?ms=fx45_beta_b1 to on-disk buildbot-configs/mozilla/l10n-changesets_mozilla-beta ... 2016-01-27 01:28:35,331 : INFO : Comparing l10n changesets to shipped locales ... 2016-01-27 01:28:35,332 : ERROR : l10n_changesets and shipped_locales differ on locales: ['gn'] 2016-01-27 01:28:35,332 : ERROR : Error verifying l10n_changesets matches shipped_locales l10n.m.o didn't provide the l10n changeset for this locale. I went on https://hg.mozilla.org/releases/l10n/mozilla-beta/gn and used 2b9bb3cc4e54 as changeset
backed out from beta in https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=fa05149b610d
Can we land this again? Should I approve a changeset sign-off before it lands?
Yes, we can. Please sign off when you can. Thanks!
Awesome! I signed off on revision 9846a32f9c8f.
Is there anything more we need to do? Can we land this again before Beta 2 please?
sylvestre is this ok to land now ?
Flags: needinfo?(cbook) → needinfo?(sledru)
Grabbing that needinfo from Sylvestre, as I have the data. Yes, this is good to land now, and should land before the GTB for Beta 2. Flagging back the needinfo for landing, lacking a better idea of how to flag my intent.
Flags: needinfo?(sledru) → needinfo?(cbook)
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.