Closed
Bug 1241916
Opened 8 years ago
Closed 8 years ago
[gn] Add gn locale to browser/locales/shipped-locales for Fx45
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox45 fixed, firefox46 fixed)
RESOLVED
FIXED
mozilla45
People
(Reporter: gueroJeff, Assigned: gueroJeff)
References
Details
Attachments
(1 file)
427 bytes,
patch
|
delphine
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The Guaraní (gn) locale is ready to be added to shipped-locales for Aurora and Beta. The attached patch adds the locale for Aurora, but we'd like this to also be ported to Beta. Also, please do not reset all-locales and shipped-locales during merge day. As usual, this is not going to land on mozilla-central, as the l10n config there is just for nightly. As I do not have commit access, this patch will need to be commited for me please.
Attachment #8711028 -
Flags: review?(l10n)
Attachment #8711028 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•8 years ago
|
Blocks: fx-l10n-gn
Assignee | ||
Updated•8 years ago
|
Attachment #8711028 -
Flags: review?(l10n) → review?(lebedel.delphine)
Comment 1•8 years ago
|
||
Comment on attachment 8711028 [details] [diff] [review] add-gn-shipped-locales.patch Looks good to me. r+
Attachment #8711028 -
Flags: review?(lebedel.delphine) → review+
Assignee | ||
Comment 2•8 years ago
|
||
Hey Ryan, I need to get this patch landed before merge day. Could you take a look at it for me please for mozilla-aurora landing permission? The questions didn't pop up for me when I flagged it. The risk here is low, especially as long as we do not reset all-locales and shipped-locales during merge day. Thanks, Jeff
Flags: needinfo?(ryanvm)
Comment 3•8 years ago
|
||
Release Management handles approvals, not me.
Flags: needinfo?(ryanvm) → needinfo?(sledru)
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #3) > Release Management handles approvals, not me. Thank you. Sorry for the confusion.
Comment 5•8 years ago
|
||
Comment on attachment 8711028 [details] [diff] [review] add-gn-shipped-locales.patch Sure
Flags: needinfo?(sledru)
Attachment #8711028 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 6•8 years ago
|
||
Thank you. Can we make sure this gets landed and ported to Beta today so we get Beta builds for this locale out as early as possible please?
Whiteboard: checkin-needed-aurora
Updated•8 years ago
|
Attachment #8711028 -
Attachment is patch: true
Attachment #8711028 -
Attachment mime type: text/x-patch → text/plain
Comment 7•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/3bc504ea394f
status-firefox45:
--- → fixed
Comment 8•8 years ago
|
||
Landed on Aurora46 as well. https://hg.mozilla.org/releases/mozilla-aurora/rev/302ab550a227
Assignee: nobody → jbeatty
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Whiteboard: checkin-needed-aurora
Assignee | ||
Comment 9•8 years ago
|
||
Thanks all!
Comment 10•8 years ago
|
||
This broke the build 2016-01-27 01:28:34,686 : INFO : Comparing l10n changesets on dashboard https://l10n.mozilla.org/shipping/l10n-changesets?ms=fx45_beta_b1 to on-disk buildbot-configs/mozilla/l10n-changesets_mozilla-beta ... 2016-01-27 01:28:35,331 : INFO : Comparing l10n changesets to shipped locales ... 2016-01-27 01:28:35,332 : ERROR : l10n_changesets and shipped_locales differ on locales: ['gn'] 2016-01-27 01:28:35,332 : ERROR : Error verifying l10n_changesets matches shipped_locales l10n.m.o didn't provide the l10n changeset for this locale. I went on https://hg.mozilla.org/releases/l10n/mozilla-beta/gn and used 2b9bb3cc4e54 as changeset
Comment 11•8 years ago
|
||
backed out from beta in https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=fa05149b610d
Assignee | ||
Comment 12•8 years ago
|
||
Can we land this again? Should I approve a changeset sign-off before it lands?
Flags: needinfo?(sledru)
Assignee | ||
Comment 14•8 years ago
|
||
Awesome! I signed off on revision 9846a32f9c8f.
Assignee | ||
Comment 15•8 years ago
|
||
Is there anything more we need to do? Can we land this again before Beta 2 please?
Flags: needinfo?(cbook)
Comment 16•8 years ago
|
||
sylvestre is this ok to land now ?
Flags: needinfo?(cbook) → needinfo?(sledru)
Comment 17•8 years ago
|
||
Grabbing that needinfo from Sylvestre, as I have the data. Yes, this is good to land now, and should land before the GTB for Beta 2. Flagging back the needinfo for landing, lacking a better idea of how to flag my intent.
Flags: needinfo?(sledru) → needinfo?(cbook)
Comment 18•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/32bb82b87b60
Comment 20•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
Updated•6 years ago
|
Target Milestone: Firefox 45 → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•