Closed Bug 1241955 Opened 4 years ago Closed 4 years ago

Enable tests on date

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: jlund)

References

Details

Attachments

(1 file, 1 obsolete file)

Ryan asked today what the default update channel is in release promotion and mentioned that some tests may fail if they get an update prompt.

We should enable tests to see what else is broken :)
Attached patch enable_tests.diff (obsolete) — Splinter Review
Assignee: nobody → rail
Attachment #8717287 - Flags: review?(bugspam.Callek)
Comment on attachment 8717287 [details] [diff] [review]
enable_tests.diff

Review of attachment 8717287 [details] [diff] [review]:
-----------------------------------------------------------------

I'd be interested in an explicit builderlist diff with this. As well as a verification we're not tripping over the max builders per master PB_* setting as a sanity check.

That said, even if we are we should find some way to accommodate this for our needs. -- r+ unless there is wider changes needed.
Attachment #8717287 - Flags: review?(bugspam.Callek) → review+
judging by my verify_patch script I don't think this patch will be enough. We may need to tweak something like 'platforms' or the 'slave_platforms' within 'platforms': https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla/project_branches.py#143
builder_diff of this patch: http://people.mozilla.org/~jlund/date_unittests-builder_diff.diff

notice this jumps us by 5% to 98% cap

the previous patch yielded a no-op diff without removing slave_platforms from the platforms list.
Attachment #8720143 - Flags: review?(bugspam.Callek)
Comment on attachment 8720143 [details] [diff] [review]
160216_date_unittests.patch

Review of attachment 8720143 [details] [diff] [review]:
-----------------------------------------------------------------

I'm saddened at buildercount concerns here..... fwiw.
Attachment #8720143 - Flags: review?(bugspam.Callek) → review+
Attachment #8717287 - Attachment is obsolete: true
Assignee: rail → jlund
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.