Add a description of e10s blocked status to about:support

RESOLVED FIXED in Firefox 46

Status

()

Toolkit
General
RESOLVED FIXED
2 years ago
9 months ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

Trunk
mozilla46
Points:
---

Firefox Tracking Flags

(e10sm8+, firefox46 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
There's currently a vague note saying the reason that e10s was disabled, which shows up in the e10s checkbox in the preferences dialog. But:
 - that note is not localized
 - it shows up only in nightly/aurora

We should move this to about:support which will better help end users once e10s is released.

The patch also improves things a bit by also displaying a description for enabled by user/by default/disabled..  And the handling of the checkbox can be simplified and the msg logged to the console removed.

I'd really like to get this in 46 because it contains strings that can't be uplifted.
(Assignee)

Comment 1

2 years ago
Created attachment 8711082 [details]
MozReview Request: Bug 1241959 - Add a description of e10s blocked status to about:support. r?jimm

Review commit: https://reviewboard.mozilla.org/r/31973/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31973/
Attachment #8711082 - Flags: review?(jmathies)
(Assignee)

Updated

2 years ago
Component: General → General
Product: Firefox → Toolkit
Version: 44 Branch → Trunk

Comment 2

2 years ago
Comment on attachment 8711082 [details]
MozReview Request: Bug 1241959 - Add a description of e10s blocked status to about:support. r?jimm

https://reviewboard.mozilla.org/r/31973/#review28741

::: browser/components/preferences/in-content/main.js:88
(Diff revision 1)
> -    // the checkbox.
> +    let e10sTempPref = document.getElementById("e10sTempPref");

I think we need to add a check here for 'browser.tabs.remote.force-enable' with an additional preferecne entry. If that's set the checkbox won't be.
Attachment #8711082 - Flags: review?(jmathies)
(Assignee)

Comment 3

2 years ago
Comment on attachment 8711082 [details]
MozReview Request: Bug 1241959 - Add a description of e10s blocked status to about:support. r?jimm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31973/diff/1-2/
Attachment #8711082 - Flags: review?(jmathies)

Updated

2 years ago
Attachment #8711082 - Flags: review?(jmathies) → review+

Comment 4

2 years ago
Comment on attachment 8711082 [details]
MozReview Request: Bug 1241959 - Add a description of e10s blocked status to about:support. r?jimm

https://reviewboard.mozilla.org/r/31973/#review28747

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7cfbfa5847c

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/50875d44e5c5
Sorry, didn't catch that there was a followup, so backed out the original patch in https://hg.mozilla.org/integration/mozilla-inbound/rev/a6fed22899b2

Relanded it in https://hg.mozilla.org/integration/mozilla-inbound/rev/2f83d8624aa6 since the followup appears to have fixed it.

Comment 8

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f83d8624aa6

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/50875d44e5c5
https://hg.mozilla.org/mozilla-central/rev/2f83d8624aa6
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46

Updated

a year ago
Depends on: 1327380
See Also: → bug 1330541
You need to log in before you can comment on or make changes to this bug.