Closed Bug 1241959 Opened 5 years ago Closed 5 years ago

Add a description of e10s blocked status to about:support

Categories

(Toolkit :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
e10s m8+ ---
firefox46 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

Attachments

(1 file)

There's currently a vague note saying the reason that e10s was disabled, which shows up in the e10s checkbox in the preferences dialog. But:
 - that note is not localized
 - it shows up only in nightly/aurora

We should move this to about:support which will better help end users once e10s is released.

The patch also improves things a bit by also displaying a description for enabled by user/by default/disabled..  And the handling of the checkbox can be simplified and the msg logged to the console removed.

I'd really like to get this in 46 because it contains strings that can't be uplifted.
Product: Firefox → Toolkit
Version: 44 Branch → Trunk
Comment on attachment 8711082 [details]
MozReview Request: Bug 1241959 - Add a description of e10s blocked status to about:support. r?jimm

https://reviewboard.mozilla.org/r/31973/#review28741

::: browser/components/preferences/in-content/main.js:88
(Diff revision 1)
> -    // the checkbox.
> +    let e10sTempPref = document.getElementById("e10sTempPref");

I think we need to add a check here for 'browser.tabs.remote.force-enable' with an additional preferecne entry. If that's set the checkbox won't be.
Attachment #8711082 - Flags: review?(jmathies)
Comment on attachment 8711082 [details]
MozReview Request: Bug 1241959 - Add a description of e10s blocked status to about:support. r?jimm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31973/diff/1-2/
Attachment #8711082 - Flags: review?(jmathies)
Attachment #8711082 - Flags: review?(jmathies) → review+
Comment on attachment 8711082 [details]
MozReview Request: Bug 1241959 - Add a description of e10s blocked status to about:support. r?jimm

https://reviewboard.mozilla.org/r/31973/#review28747
Sorry, didn't catch that there was a followup, so backed out the original patch in https://hg.mozilla.org/integration/mozilla-inbound/rev/a6fed22899b2

Relanded it in https://hg.mozilla.org/integration/mozilla-inbound/rev/2f83d8624aa6 since the followup appears to have fixed it.
https://hg.mozilla.org/mozilla-central/rev/50875d44e5c5
https://hg.mozilla.org/mozilla-central/rev/2f83d8624aa6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Depends on: 1327380
See Also: → 1330541
You need to log in before you can comment on or make changes to this bug.