1241959 - Add a description of e10s blocked status to about:support

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

There's currently a vague note saying the reason that e10s was disabled, which shows up in the e10s checkbox in the preferences dialog. But:
 - that note is not localized
 - it shows up only in nightly/aurora

We should move this to about:support which will better help end users once e10s is released.

The patch also improves things a bit by also displaying a description for enabled by user/by default/disabled..  And the handling of the checkbox can be simplified and the msg logged to the console removed.

I'd really like to get this in 46 because it contains strings that can't be uplifted.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: MozReview Request: Bug 1241959 - Add a description of e10s blocked status to about:support. r?jimm

Review commit: https://reviewboard.mozilla.org/r/31973/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31973/

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8711082 [details]
MozReview Request: Bug 1241959 - Add a description of e10s blocked status to about:support. r?jimm

https://reviewboard.mozilla.org/r/31973/#review28741

::: browser/components/preferences/in-content/main.js:88
(Diff revision 1)
> -    // the checkbox.
> +    let e10sTempPref = document.getElementById("e10sTempPref");

I think we need to add a check here for 'browser.tabs.remote.force-enable' with an additional preferecne entry. If that's set the checkbox won't be.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8711082 [details]
MozReview Request: Bug 1241959 - Add a description of e10s blocked status to about:support. r?jimm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31973/diff/1-2/

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8711082 [details]
MozReview Request: Bug 1241959 - Add a description of e10s blocked status to about:support. r?jimm

https://reviewboard.mozilla.org/r/31973/#review28747

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7cfbfa5847c

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/50875d44e5c5

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Sorry, didn't catch that there was a followup, so backed out the original patch in https://hg.mozilla.org/integration/mozilla-inbound/rev/a6fed22899b2

Relanded it in https://hg.mozilla.org/integration/mozilla-inbound/rev/2f83d8624aa6 since the followup appears to have fixed it.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f83d8624aa6

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/50875d44e5c5
https://hg.mozilla.org/mozilla-central/rev/2f83d8624aa6