Closed Bug 1241973 Opened 9 years ago Closed 9 years ago

Change LocaleFields into FKs into a locale table controlled by product_details

Categories

(Shield :: General, defect)

Product:
Shield
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mythmon, Assigned: osmose)

References

Details

Having a LocaleField with a CHOICES field that depend on product_details is a recipe for all sorts of pain. Instead we should write a custom backend for product_details that reifies the locales into rows in the database that we can have foreign keys to.
This is already in progress in PR 9: https://github.com/mozilla/normandy/pull/9
Fixed in https://github.com/mozilla/normandy/commit/839b037e89449d630ccf8e3ddc2f9ef275756dc2.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 1248319
Component: SHIELD → General
Product: Websites → Normandy
You need to log in before you can comment on or make changes to this bug.