1241983 - nsDOMIdentity's dom-window-destroyed handler is bogus

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

See bug 1241763 comment 4.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

For reference, this landed because I was trying to fix some warnings that were actually a red herring to the original problem I was fixing with async settings. See https://bugzilla.mozilla.org/show_bug.cgi?id=1065128#c18. I think we can just undo the patch (doubt it'll be a straight backout since it's been so long, but we'll see) and be ok.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Make DOM Identity observe inner-window-destroyed not dom-window-destroyed

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Well, try is clean on this at least.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=82ff69cb3fe5

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d57e965c2f56

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d57e965c2f56