Closed Bug 1241996 Opened 8 years ago Closed 8 years ago

Fix toolkit/mozapps/extensions/test/browser/browser_select_confirm.js for bug 1231784

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: ahal, Unassigned)

References

Details

I'm trying to get mochitest working with addon signing enforced. Part of that is to install the mochikit and specialpowers extensions via 'installTemporaryAddons()'. This causes toolkit/mozapps/extensions/test/browser/browser_select_confirm.js to fail because mochikit@mozilla.org and specialpowers@mozilla.org now both appear in 'selectAddons.xul'.

I could fix this by simply changing the test assertions to match the new reality, but this breaks the spirit of the test (e.g testing what happens when all addons get disabled). Ideally we'd somehow exclude mochikit and specialpowers from showing up in selectAddons.xul, but I don't know how to do this. Any help would be much appreciated!

STR:
1. Pull in changes from bug 1231784:
hg pull -r 23b5a3805ce3a3d9112092645fbc62d17bd970da https://reviewboard-hg.mozilla.org/gecko

2. Re-build mochitest:
./mach build testing/mochitest

3. Run:
./mach mochitest toolkit/mozapps/extensions/test/browser/browser_select_config.js
Ah actually, I guess since mochikit and specialpowers are temporary, they're now set to be disabled and are part of 'disable list'. So maybe updating the assertions is the proper fix here after all.
Sorry for the bug churn. This seems like a simple update I can do as part of bug 1231784. It makes more sense to keep it in the same patch series on mozreview, so closing this bug.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.