1242025 - "Delete" in Logins/LoginManager appears not localized

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Plewako [:stef]]

TestFlight 2.0 (2): Settings → Logins → "Delete" in the upper left corner appears not localized.

Comment 1

[Stefan Plewako [:stef]]

It should be: Settings → Logins → Edit → select item → "Delete" in the upper left corner appears not localized.

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1471

I've copied over the localized 'Delete' string used for the Login Detail since we don't have one with a proper comment for the list view. This isn't ideal but I think it's too late to add a string with a different comment even though its the same string.

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8711658 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1471

Comments actually don't affect localization -- it will show up as a duplicate entry of the same string with a different comment (as long as the key and table name are the same).

That's the reason we were considering switching to a unique ID-based system for NSLocalizedString: strings in different contexts that are the same in English will have the same key, but those strings might not be the same in other languages, and there's no good way to separate them now (unless we put them in a different table, which is sometimes a hack).

In this case, the string collapsing behavior will actually help you out since you don't want to introduce new strings now :)

Comment 4

[Stephan Leroux [:sleroux]]

master f40df4af1bebae616fc6d0596143932ea81a7ce5

Comment 5

[Stephan Leroux [:sleroux]]

v3.x 10e88e1