"Delete" in Logins/LoginManager appears not localized

RESOLVED FIXED in 4.0

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: stef, Assigned: sleroux)

Tracking

unspecified
All
iOS
Dependency tree / graph

Firefox Tracking Flags

(fxios-v3.0 fixed, fxios-v4.0 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
TestFlight 2.0 (2): Settings → Logins → "Delete" in the upper left corner appears not localized.
(Reporter)

Comment 1

3 years ago
It should be: Settings → Logins → Edit → select item → "Delete" in the upper left corner appears not localized.
Blocks: 1210103
Flags: needinfo?(sleroux)
Hardware: Other → All
(Assignee)

Updated

3 years ago
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
Flags: needinfo?(sleroux)
(Assignee)

Comment 2

3 years ago
Created attachment 8711658 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1471

I've copied over the localized 'Delete' string used for the Login Detail since we don't have one with a proper comment for the list view. This isn't ideal but I think it's too late to add a string with a different comment even though its the same string.
Attachment #8711658 - Flags: review?(bnicholson)
(Reporter)

Updated

3 years ago
Blocks: 1242542
Comment on attachment 8711658 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1471

Comments actually don't affect localization -- it will show up as a duplicate entry of the same string with a different comment (as long as the key and table name are the same).

That's the reason we were considering switching to a unique ID-based system for NSLocalizedString: strings in different contexts that are the same in English will have the same key, but those strings might not be the same in other languages, and there's no good way to separate them now (unless we put them in a different table, which is sometimes a hack).

In this case, the string collapsing behavior will actually help you out since you don't want to introduce new strings now :)
Attachment #8711658 - Flags: review?(bnicholson) → feedback+
Blocks: 1256395
(Assignee)

Comment 4

3 years ago
master f40df4af1bebae616fc6d0596143932ea81a7ce5
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-fxios-v4.0: --- → fixed
Resolution: --- → FIXED
Whiteboard: [needsuplift]
Target Milestone: --- → 4.0
(Assignee)

Comment 5

3 years ago
v3.x 10e88e1
status-fxios-v3.0: --- → fixed
Whiteboard: [needsuplift]
You need to log in before you can comment on or make changes to this bug.