1242055 - Change "Record Allocation stacks" to an icon

Status: NEW

(DevTools :: Memory, defect, P2)

Description

[Tim Nguyen :ntim]

The checkbox currently looks odd, especially the label that looks concatenated with "View:".

Comment 1

[Tim Nguyen :ntim]

Attachment: Possible icon 1

Comment 2

[Tim Nguyen :ntim]

Attachment: Possible icon 2

Comment 3

[Helen V. Holmes (:helenvholmes) (:✨)]

Tim, I know there was some discussion on IRC about this and why it made sense. Can you recap it here for me?

Comment 4

[Tim Nguyen :ntim]

(In reply to Helen V. Holmes (:helenvholmes) (:✨) from comment #3)
> Tim, I know there was some discussion on IRC about this and why it made
> sense. Can you recap it here for me?

This idea was brought up to fix a current esthetic issue (how the checkboxes are oddly placed). Then we thought an icon was better for these reasons:
- the "Invert tree" checkbox is context aware (and disappears in some situations), the "Record Allocation Stacks" checkbox doesn't follow that pattern.
- The "Record Allocation Stacks" only affects future recordings, not the current one

Start of the conversation: http://logs.glob.uno/?c=mozilla%23devtools&s=22+Jan+2016&e=22+Jan+2016#c153120
Where it gets interesting: http://logs.glob.uno/?c=mozilla%23devtools&s=22+Jan+2016&e=22+Jan+2016#c153214

Comment 5

[Helen V. Holmes (:helenvholmes) (:✨)]

Was it not originally made into a checkbox because it was an option when recording?

Comment 6

[Tim Nguyen :ntim]

(In reply to Helen V. Holmes (:helenvholmes) (:✨) from comment #5)
> Was it not originally made into a checkbox because it was an option when
> recording?

Yes.