1242070 - Autophone - adb.py - use native recursion with chmod when supported by the device.

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

chmod in particular is a problem for performance now that we have to use it to change permissions on pushed directories and profiles and since we emulate recursion rather than take advantage of the native support on the device. I experimented a bit and think that a test command using --help shows a help message which usually contains some indication whether the device natively supports recursion (usually with the option -R). This will correctly detect chmod -R on nexus 4,5,7,6,6p while not detecting it on nexus s where it is not supported. I'm pulling a bunch of system images to try it out with so I'll have a better idea interms of aosp emulators in a bit.

I think this will help our throughput significantly by reducing the time spent chmodding directories.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1242070-v1.patch

I've been testing this patch on staging. See https://treeherder.allizom.org/#/jobs?filter-searchStr=autophone&exclusion_profile=false&repo=mozilla-inbound&filter-tier=1&filter-tier=2&filter-tier=3&fromchange=596388fc0ff4

The Nexus 6P's are really falling behind and could use the benefit of this patch.

Before this patch, in my local environment the Nexus 6P took between 13-35 minutes to run the S1S2 tests. See https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound&revision=2f83d8624aa6&exclusion_profile=false&filter-tier=1&filter-tier=2&filter-tier=3&filter-searchStr=autophone&selectedJob=17735522

After this patch, the tests take about 4 minutes each.

I'm going to go ahead and land this. We can do a formal review when I work up patches for mozdevice's version of adb.py.

Comment 2

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/8343fa1accc064d48b00ad85b3c24a3c7966aa64

autophone-1 2016-01-24 12:06:56 Autophone started.
autophone-2 2016-01-24 12:08:27 Autophone started.
autophone-3 2016-01-24 12:07:29 Autophone started.