Closed Bug 1242108 Opened 9 years ago Closed 8 years ago

Intermittent TEST-UNEXPECTED-FAIL | /old-tests/submission/Microsoft/sandbox/sandbox_002.htm | Allow autoplay for HTML5 Video inside iframe with sandbox attribute if sandbox='allow-scripts'. - event is undefined

Categories

(Testing :: web-platform-tests, defect)

defect
Not set
normal

Tracking

(firefox46 fixed, firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: philor, Assigned: jgraham)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Looks like a test trying to make itself time out early. Could you fix?
Flags: needinfo?(james)
Attached patch 1242108.diffSplinter Review
Flags: needinfo?(james)
Attachment #8713564 - Flags: review?(Ms2ger)
Comment on attachment 8713564 [details] [diff] [review]
1242108.diff

Review of attachment 8713564 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

::: testing/web-platform/tests/old-tests/submission/Microsoft/sandbox/sandbox_002.htm
@@ +2,4 @@
>  <html>
>  <head>
>      <title>HTML5 Sandbox: Allow autoplay for HTML5 Video inside iframe with sandbox attribute if sandbox='allow-scripts'.</title>
> +    <meta name=timeout content=long>

Is this necessary? Nothing here should take long, it seems.

@@ +10,5 @@
>  </head>
>  <body>
> +    <script>
> +      async_test(function (t) {
> +        callback = t.step_func_done(function(event) {

Add `var` (or inline into `addEventListener`)
Attachment #8713564 - Flags: review?(Ms2ger) → review+
https://hg.mozilla.org/mozilla-central/rev/6cb573852b95
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Assignee: nobody → james
Whiteboard: [checkin-needed-aurora]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: