Closed Bug 1242120 Opened 5 years ago Closed 5 years ago

Remove switch fallthrough to avoid -Wimplicit-fallthrough warning in dom/canvas/

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional, but in this case, the switch code can be rearranged to return without falling through.

dom/canvas/WebGLContextGL.cpp:1329:9: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
Attachment #8711288 - Flags: review?(mtseng)
Attachment #8711288 - Flags: review?(mtseng) → review+
Thanks for the fast review! :)
https://hg.mozilla.org/mozilla-central/rev/efdb4c508dd3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Blocks: 1253170
You need to log in before you can comment on or make changes to this bug.