Remove switch fallthrough to avoid -Wimplicit-fallthrough warning in dom/canvas/

RESOLVED FIXED in Firefox 46

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

Trunk
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8711288 [details] [diff] [review]
Wimplicit-fallthrough_WebGLContextGL.patch

clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional, but in this case, the switch code can be rearranged to return without falling through.

dom/canvas/WebGLContextGL.cpp:1329:9: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
Attachment #8711288 - Flags: review?(mtseng)
Attachment #8711288 - Flags: review?(mtseng) → review+
(Assignee)

Comment 1

2 years ago
Thanks for the fast review! :)

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/efdb4c508dd3
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
(Assignee)

Updated

2 years ago
Blocks: 1253170
You need to log in before you can comment on or make changes to this bug.