Strip paths from bug searches for assertions so they'll be starrable

NEW
Unassigned

Status

Tree Management
Treeherder: Log Parsing & Classification
2 years ago
5 months ago

People

(Reporter: philor, Unassigned)

Tracking

Details

(Reporter)

Description

2 years ago
Assertion failures have failure messages of the form "Assertion failure: !mCanSend, at /builds/slave/fx-team-lx-d-00000000000000000/build/src/gfx/layers/ipc/CompositorChild.cpp:398" so the bug search is for "Assertion failure: !mCanSend, at /builds/slave/fx-team-lx-d-00000000000000000/build/src/gfx/layers/i" so they can't be matched without filing a separate bug for every tree and every platform.

If instead we stripped the path the way we strip paths from test filenames before searching, we could actually file on assertions rather than filing on the rarely-useful crash stack and confusing people into thinking that what happened was a crash rather than an assertion, or thinking that two failures from different assertions that happen to have the same meaningless crash signature are the same bug.

Comment 1

2 years ago
(In reply to Phil Ringnalda (:philor) from comment #0)
> Assertion failures have failure messages of the form "Assertion failure:
> !mCanSend, at
> /builds/slave/fx-team-lx-d-00000000000000000/build/src/gfx/layers/ipc/
> CompositorChild.cpp:398" so the bug search is for "Assertion failure:
> !mCanSend, at
> /builds/slave/fx-team-lx-d-00000000000000000/build/src/gfx/layers/i" so they
> can't be matched without filing a separate bug for every tree and every
> platform.

Ted, would it be practical to make the assertion failure error messages output a relative path instead?

I'd prefer to fix this at the source rather than work around it in Treeherder, if possible :-)
Flags: needinfo?(ted)
I think it'd be hard to do at the *actual* source, which just prints __FILE__:
https://dxr.mozilla.org/mozilla-central/rev/aa90f482e16db77cdb7dea84564ea1cbd8f7f6b3/mfbt/Assertions.h#372

We could, however, post-process this in test harnesses, which is sort of a pain but relatively feasible.
Flags: needinfo?(ted)

Updated

8 months ago
Component: Treeherder → Treeherder: Log Parsing & Classification
You need to log in before you can comment on or make changes to this bug.