1242295 - nsDeviceContextSpecWin.cpp(447): error C2664: 'HDC CreateICW(LPCWSTR,LPCWSTR,LPCWSTR,const DEVMODEW *)': cannot convert argument 2 from 'const char16_t *' to 'LPCWSTR'

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

New compile error with VS2015:
 6:13.46 widget/windows/nsDeviceContextSpecWin.cpp(447): error C2664: 'HDC CreateICW(LPCWSTR,LPCWSTR,LPCWSTR,const DEVMODEW *)': cannot convert argument 2 from 'const char16_t *' to 'LPCWSTR'
 6:13.46 widget/windows/nsDeviceContextSpecWin.cpp(447): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Attachment: MozReview Request: Bug 1242295 - Fix compile error in nsDeviceContextSpecWin. r?jimm

Review commit: https://reviewboard.mozilla.org/r/32225/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32225/

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8711511 [details]
MozReview Request: Bug 1242295 - Fix compile error in nsDeviceContextSpecWin. r?jimm

https://reviewboard.mozilla.org/r/32225/#review29071

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2570e9fe3098dd3b7fa96ba3641b739fe540a147
Bug 1242295 - Fix compile error in nsDeviceContextSpecWin. r=jimm

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2570e9fe3098

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8711511 [details]
MozReview Request: Bug 1242295 - Fix compile error in nsDeviceContextSpecWin. r?jimm

Approval Request Comment
[Feature/regressing bug #]: bug 1238964
[User impact if declined]: no user impact, but developers who use VS2015 would not be able to compile the aurora branch
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: no risk, just fix a compile error on VS2015
[String/UUID change made/needed]: n/a

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Recent regression, tracking.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8711511 [details]
MozReview Request: Bug 1242295 - Fix compile error in nsDeviceContextSpecWin. r?jimm

Fix for recent regression, please uplift to aurora.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f419b0938dad