1242336 - Pass WebGL2 conformance test gl-get-calls

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ethan Lin[:ethlin]]

FAIL context.getParameter(context.UNPACK_SKIP_IMAGES) should be 0 (of type number). Was false (of type boolean).
FAIL context.getParameter(context.UNPACK_SKIP_PIXELS) should be 0 (of type number). Was false (of type boolean).
FAIL context.getParameter(context.UNPACK_SKIP_ROWS) should be 0 (of type number). Was false (of type boolean).

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Fix return type.

According to the spec[1], GL_PACK_SKIP_PIXELS, GL_PACK_SKIP_ROWS, GL_PIXEL_PACK_BUFFER_BINDING should return the number of something. So I change the return type to integer.

[1] https://www.khronos.org/opengles/sdk/docs/man3/html/glGet.xhtml

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8711568 [details] [diff] [review]
Fix return type.

Review of attachment 8711568 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextState.cpp
@@ +80,5 @@
>      case LOCAL_GL_UNPACK_IMAGE_HEIGHT:
> +    case LOCAL_GL_UNPACK_ROW_LENGTH:
> +    case LOCAL_GL_UNPACK_SKIP_IMAGES:
> +    case LOCAL_GL_UNPACK_SKIP_PIXELS:
> +    case LOCAL_GL_UNPACK_SKIP_ROWS: {

We cache these. Just return the cached values.

Comment 3

[Ethan Lin[:ethlin]]

Attachment: Fix return type.

Addressed jgilbert's comment. I think we should also use the cached value for LOCAL_GL_PACK_ROW_LENGTH, LOCAL_GL_PACK_SKIP_ROWS, etc. I will open another bug to do that.

Comment 4

[Ethan Lin[:ethlin]]

try server result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ffe9bad1836

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78ee856813f0

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/78ee856813f0