Closed Bug 1242349 Opened 8 years ago Closed 8 years ago

Provide unique pref to modify AccessibleCaret behavior in content initiated selection changes

Categories

(Core :: DOM: Selection, defect)

Product:
Core
Component:
DOM: Selection
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: capella, Assigned: capella)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

bug1242349.diff
6.65 KB, patch
TYLin
: review+
Details | Diff | Splinter Review 
The default behavior for layout/core AccessibleCaretManager when responding to Javascript / content initiated selection changes is to HideCarets(), which closes the FFOS UtilityBubble and its counterpart, the mobile ActionBarHandler.

When mobile implemented bug 1215959, we extended the logic [0] to attempt backwards compatibility we previous behaviors, for ex: Bug 1096938 

This is currently preffed behind: |layout.accessiblecaret.extendedvisibility|, which is a catch-all for mobile compatibility behaviour: [1], and might be properly broken out into a unique pref, at least until there's a consensus on UI behavior.


[0] http://mxr.mozilla.org/mozilla-central/source/layout/base/AccessibleCaretManager.cpp?rev=0ff0ab3c254a&mark=131-138#129
[1] http://mxr.mozilla.org/mozilla-central/search?string=sCaretsExtendedVisibility&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
For plong-term planning, also keep in mind: Bug 1171110 - Floating text selection action bar for Android M , which will provide mobile with an FFOS-like UtilityBubble
Attached patch bug1242349.diff — — Splinter Review 
Can I ask you to review this?
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attachment #8712036 - Flags: review?(tlin)
Comment on attachment 8712036 [details] [diff] [review]
bug1242349.diff

Review of attachment 8712036 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a de facto owner of AccessibleCaret, so I think I can review this patch :-)

If the patch touches other layout code, :roc is the person to ask for review.
Attachment #8712036 - Flags: review?(tlin) → review+
https://hg.mozilla.org/mozilla-central/rev/39680e485454
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.