1242349 - Provide unique pref to modify AccessibleCaret behavior in content initiated selection changes

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Mark Capella [:capella]]

The default behavior for layout/core AccessibleCaretManager when responding to Javascript / content initiated selection changes is to HideCarets(), which closes the FFOS UtilityBubble and its counterpart, the mobile ActionBarHandler.

When mobile implemented bug 1215959, we extended the logic [0] to attempt backwards compatibility we previous behaviors, for ex: Bug 1096938 

This is currently preffed behind: |layout.accessiblecaret.extendedvisibility|, which is a catch-all for mobile compatibility behaviour: [1], and might be properly broken out into a unique pref, at least until there's a consensus on UI behavior.


[0] http://mxr.mozilla.org/mozilla-central/source/layout/base/AccessibleCaretManager.cpp?rev=0ff0ab3c254a&mark=131-138#129
[1] http://mxr.mozilla.org/mozilla-central/search?string=sCaretsExtendedVisibility&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 1

[Mark Capella [:capella]]

For plong-term planning, also keep in mind: Bug 1171110 - Floating text selection action bar for Android M , which will provide mobile with an FFOS-like UtilityBubble

Comment 2

[Mark Capella [:capella]]

Attachment: bug1242349.diff

Can I ask you to review this?

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8712036 [details] [diff] [review]
bug1242349.diff

Review of attachment 8712036 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a de facto owner of AccessibleCaret, so I think I can review this patch :-)

If the patch touches other layout code, :roc is the person to ask for review.

Comment 4

[Mark Capella [:capella]]

Try push looks good
https://treeherder.mozilla.org/#/jobs?repo=try&revision=128bea4e4045

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/39680e485454

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/39680e485454