Add license header to DownloadContentService

RESOLVED FIXED in Firefox 47

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sebastian, Assigned: Maurya Talisetti, Mentored)

Tracking

unspecified
Firefox 47
All
Android
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
This is a very simple good first bug: DownloadContentService is missing our license header:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/dlc/DownloadContentService.java#1

Copy it from a different file, for example from here:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/dlc/DownloadAction.java#1-5


To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

hen, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
(Assignee)

Comment 1

2 years ago
Created attachment 8711610 [details] [diff] [review]
license-header-for-DownloadContentService
Attachment #8711610 - Flags: review?(s.kaspari)
(Reporter)

Updated

2 years ago
Assignee: nobody → maurya1985
Status: NEW → ASSIGNED
(Reporter)

Comment 2

2 years ago
Comment on attachment 8711610 [details] [diff] [review]
license-header-for-DownloadContentService

Something went wrong here. The patch file is empty.
Attachment #8711610 - Flags: review?(s.kaspari)
(Assignee)

Comment 3

2 years ago
Created attachment 8711613 [details] [diff] [review]
license-header-for-DownloadContentService
Attachment #8711610 - Attachment is obsolete: true
Attachment #8711613 - Flags: review?(s.kaspari)
(Reporter)

Comment 4

2 years ago
Comment on attachment 8711613 [details] [diff] [review]
license-header-for-DownloadContentService

Review of attachment 8711613 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome. Thank you for this fast patch!
Attachment #8711613 - Flags: review?(s.kaspari) → review+
(Reporter)

Comment 5

2 years ago
This just adds a license header and doesn't need a test run: checkin-needed.
Keywords: checkin-needed
(Reporter)

Updated

2 years ago
Blocks: 1197720

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/22a307cc8cf9
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.