Closed Bug 1242352 Opened 10 years ago Closed 10 years ago

Add license header to DownloadContentService

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox47 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: sebastian, Assigned: maurya1985, Mentored)

References

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 file, 1 obsolete file)

license-header-for-DownloadContentService
1.05 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
This is a very simple good first bug: DownloadContentService is missing our license header: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/dlc/DownloadContentService.java#1 Copy it from a different file, for example from here: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/dlc/DownloadAction.java#1-5 To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android hen, you'll need to create a patch to upload - see https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
Attachment #8711610 - Flags: review?(s.kaspari)
Assignee: nobody → maurya1985
Status: NEW → ASSIGNED
Comment on attachment 8711610 [details] [diff] [review] license-header-for-DownloadContentService Something went wrong here. The patch file is empty.
Attachment #8711610 - Flags: review?(s.kaspari)
Attachment #8711610 - Attachment is obsolete: true
Attachment #8711613 - Flags: review?(s.kaspari)
Comment on attachment 8711613 [details] [diff] [review] license-header-for-DownloadContentService Review of attachment 8711613 [details] [diff] [review]: ----------------------------------------------------------------- Awesome. Thank you for this fast patch!
Attachment #8711613 - Flags: review?(s.kaspari) → review+
This just adds a license header and doesn't need a test run: checkin-needed.
Keywords: checkin-needed
Blocks: 1197720
https://hg.mozilla.org/mozilla-central/rev/22a307cc8cf9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: