1242374 - With Firefox 44.0 Build 3 we ship firefox-44.0.sdk.zip packages for en-US win32/win64 builds

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Today I have seen a lot of test failures for our Firefox UI tests and the latest Firefox 44.0 build 3 on Windows - but only for en-US! Some deeper investigation has shown that we somehow upload some strange SDK packages for those builds to the FTP server.

http://archive.mozilla.org/pub/firefox/candidates/44.0-candidates/build3/win32/en-US/

> File 	firefox-44.0.sdk.zip 	79M 	24-Jan-2016 02:29
> File 	firefox-44.0.sdk.zip.asc 	836 	24-Jan-2016 02:29

Sadly those files are referenced in the Mozilla Pulse build notifications:

"buildurl": "http://archive.mozilla.org/pub/firefox/candidates/44.0-candidates/build3/win32/en-US/firefox-44.0.sdk.zip"

That means something in the Releng system behaves incorrectly or its something new which needs tweaking. Interesting is that no-one seems to know what this file is for. So do we really want to upload that?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I just noticed that the patch on bug 1233005 landed last week. So with that we seem to incorrectly set the buildurl. But what I still wonder is why we only upload it for win32/win64? Should this file go into another folder?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Also I do not see any SDK build under candidate builds even before Firefox 44.0.

Comment 3

[[e-mail] (:bhearsum)]

It's expected that we're building the SDK as part of Firefox now. We used to build it as part of XULRunner, but that died. This transition was done in bug 1233005.

What used to be the "buildurl" here? The firefox zip?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks like, yes. Here the buildurl for 44.0 build 1:

"buildurl": "http://archive.mozilla.org/pub/firefox/candidates/44.0-candidates/build1/win32/en-US/firefox-44.0.zip"

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Whereby an installer_url might also be great to have so that we can actually test the installer again, which we cannot do with the zip file having present only.

Comment 6

[Michael Shal [:mshal]]

Attachment: sdkurl.patch

Per our IRC discussion, this sets a dummy sdkUrl variable so we don't hit the 'else' case for packageUrl. In staging here's the before:

packageUrl: 'http://archive.mozilla.org/pub/firefox/candidates/41.0-candidates/build2/linux-i686/en-US/firefox-41.0.sdk.tar.bz2'

and after:

packageUrl: 'http://archive.mozilla.org/pub/firefox/candidates/41.0-candidates/build2/linux-i686/en-US/firefox-41.0.tar.bz2'

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 8711879 [details] [diff] [review]
sdkurl.patch

Review of attachment 8711879 [details] [diff] [review]:
-----------------------------------------------------------------

Looks plausible to me...thanks Mike!

Comment 8

[Michael Shal [:mshal]]

Comment on attachment 8711879 [details] [diff] [review]
sdkurl.patch

https://hg.mozilla.org/build/buildbotcustom/rev/34f988f27f10

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

http://hg.mozilla.org/build/buildbotcustom/rev/3d73b7d94803

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Oops, sorry about that accidental closure.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

And in production after after a reconfig.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I assume this bug can be marked as fixed now? Today's beta build didn't show any problem and I think the patch here relates to all release builds.

Comment 13

[Alex Vincent [:WeirdAl]]

Are these builds (both SDK and .exe) available on archive.mozilla.org?

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, see my comment 0. Not sure why those only appear under Windows builds.

Comment 15

[Michael Shal [:mshal]]

I believe this is fixed.