1242561 - Import missing events API schema file

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The webNavigation API schema references the "UrlFilter" type from an "events" schema file which is currently missing:

https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/api/events.json

and it should be imported in the schemas dir and registered accordingly:

- "toolkit"-level schemas
  schemas directory: toolkit/components/extensions/schemas/
  schemas registration: https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/Extension.jsm#78

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: MozReview Request: Bug 1242561 - [webext] Import missing events API schema file. r?kmag

Review commit: https://reviewboard.mozilla.org/r/47703/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47703/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8743295 [details]
MozReview Request: Bug 1242561 - [webext] Import missing events API schema file. r?kmag

https://reviewboard.mozilla.org/r/47703/#review45271

This doesn't need its own bug. Please move the patch to bug 1242522.

::: toolkit/components/extensions/Schemas.jsm:1151
(Diff revision 1)
>                              pattern,
>                              format);
>      } else if (type.type == "object" && "functions" in type) {
> -      checkTypeProperties("functions");
> +      // TODO: additionalProperties is currently unused, added to the allowed to be able
> +      // to load the event.json file.
> +      checkTypeProperties("functions", "additionalProperties");

Let's just remove the property from the schema instead.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8743295 [details]
MozReview Request: Bug 1242561 - [webext] Import missing events API schema file. r?kmag

Marking this patch as obsolete, because I'm moving the patch (tweaked based on the review comments) in Bug 1242522.

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

This has been fixed in Firefox50 as part of Bug 1242522.