12428 - [feature] need API to convert nsString to UTF8 strings

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P3)

Description

[Frank Tang]

Dan : I am not sure what you really need. Does the following API fulfill your
need ?

char* nsString::ToNewUTFCString()

Assuming it does the similar thing as ToNewCString but return UTF-8 in char*
instead.

Comment 1

[Daniel Veditz [:dveditz]]

Sure, that would work. I'd prefer the name ToNewUTF8String() though.

It should just be a simple assumption that nsString is Unicode and not call in
the charset conversion libraries. Duplicate the conversion so it loads and runs
fast. Should be a relatively trivial converter anyway.

Comment 2

[Frank Tang]

OK I have make that function for nsString . Since I have problem to create patch with my communicator 4.5, I put it under
http://warp/u/ftang/tmp/nsstring2diff.txt
I also put a patch to patch mozilla/xpcom/tests/TestCRT.cpp and include 3 test cases from the RFC

Rick, please pick up the patch and check in nsString2.{h,cpp} and TestCRT.cpp
Reassign this to RickG since rick own nsString2.{h,cpp}

Rick, This is a blocker for dveditz so please check in ASAP (by M11 please). Thanks.

dan: I think you can apply tha patch to your local tree before RickG check in.

Let me know if you still need my help. Thanks.

Comment 3

[Frank Tang]

I forgot to mention the patch to the test code is in
http://warp/u/ftang/tmp/testcrtdiff.txt

Comment 4

[Frank Tang]

I check in the code. Mark this buf fixed.

Comment 5

[msanz]

Cathleen, can you verify this?