1242856 - [a11y] Add necessary semantics to the computed styles view.

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

We should be consistent with the CSS rules inspector here and use the same semantics. It can either be a list/listbox or tree view semantics. I believe firebug has a tree. It should be in sync with the rules view of course.

Comment 1

[Patrick Brosset <:pbro>]

Triaging (filter on CLIMBING SHOES).

Comment 2

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1242856 - Add accessibility semantics to the computed styles view, r?gl!

This patch does the following:

1. Adds a semantic document role to the computed styles pane. This causes screen readers to treat it as something they can use their reading commands on for better navigation and efficiency.
2. Gives the expansion twisties a button role and a label. I am reusing the labels introduced in an earlier patch.
3. Turns the name portion of each property into a heading so screen reader users can quickly skip between them, regardless of their expanded status or not.
4. Explicitly displays the status for each rule match with visually hidden text because screen readers do not pick up text from titles on simple span elements.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88d5337be8e0
Add accessibility semantics to the computed styles view, r=gl

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for dt failures on browser_computed_getNodeInfo.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/fa34f4bc17d4868ee8341cf738dcbf96bffc83e9
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306380890&repo=autoland&lineNumber=2100

Comment 5

[Marco Zehe (:MarcoZ)]

Whoops, forgot to actually save the test file. Also, one test is still failing locally, too. Will adjust and push again tomorrow. Sorry about that!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/635d182e24be
Add accessibility semantics to the computed styles view, r=gl

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/635d182e24be