1242909 - Firefox crash : malformed CSP report-uri directive

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[gaku]

Attachment: firefox-debug_1957_2810_2016-01-26_19-57-07-724.log

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20160105164030
Firefox for Android

Steps to reproduce:

PC: User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0
Android: User-Agent: Mozilla/5.0 (Android 4.1.1; Tablet; rv:43.0) Gecko/43.0 Firefox/43.0

When browse the page that contains the malformed CSP report-uri directive, Firefox crash.

===========================================
HTTP/1.1 200 OK
Date: Tue, 26 Jan 2016 08:43:03 GMT
Content-Security-Policy: script-src 'self'; report-uri javascript:
Content-Length: 28
Connection: close
Content-Type: text/html; charset=UTF-8

<script>alert(0);</script>
===========================================

Comment 1

[:Gijs (he/him)]

https://crash-stats.mozilla.com/report/index/e8c3bfab-c74c-48b6-8200-8c5172160126

AFAICT this is a nullptr crash (at least on ff44 beta, where I tested) and so it might not need to be sec-sensitive.

Comment 2

[:Gijs (he/him)]

This code:

https://dxr.mozilla.org/mozilla-central/rev/aa90f482e16db77cdb7dea84564ea1cbd8f7f6b3/dom/security/nsCSPContext.cpp#917-919

should actually continue; if uploadChannel is null.

Comment 3

[:Gijs (he/him)]

Attachment: Patch v0.1

This should do the trick.

Comment 4

[:Gijs (he/him)]

Attachment: Patch v0.2

Now without random leftovers from another bit of work - sorry for the bugspam.

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8712101 [details] [diff] [review]
Patch v0.2

Review of attachment 8712101 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Gijs, that is indeed the right fix. I also don't think this needs to be security sensitive - feel free to open it up.

Comment 6

[:Gijs (he/him)]

Ryan, can you un-sec-sensitive this, please? Thanks!

Comment 7

[:Gijs (he/him)]

Comment on attachment 8712101 [details] [diff] [review]
Patch v0.2

Approval Request Comment
[Feature/regressing bug #]: CSP parsing
[User impact if declined]: crashes!
[Describe test coverage new/current, TreeHerder]: https://dxr.mozilla.org/mozilla-central/source/dom/security/test/csp and various other tests, but nothing specifically for this issue, it seems
[Risks and why]: very low, essentially just a nullcheck
[String/UUID change made/needed]: nope

Comment 8

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/de45c3745492

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/de45c3745492

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8712101 [details] [diff] [review]
Patch v0.2

Fix a crash, taking it.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Should be in 45 beta 2

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ff4ffb78aa56

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7cf15b20b341