Make services/common eslintable

RESOLVED FIXED in Firefox 47

Status

Cloud Services
Firefox: Common
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: hectorz, Assigned: hectorz)

Tracking

unspecified
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Blocks: 1242977
(Assignee)

Comment 1

2 years ago
Created attachment 8712164 [details]
MozReview Request: Bug 1242965 - Make services/common eslintable. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/32449/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32449/
Attachment #8712164 - Flags: review?(rnewman)
Depends on: 1237983
Comment on attachment 8712164 [details]
MozReview Request: Bug 1242965 - Make services/common eslintable. r?rnewman

https://reviewboard.mozilla.org/r/32449/#review29243

::: services/common/async.js
(Diff revision 1)
> -#ifndef MERGED_COMPARTMENT

I guess we don't do this any more!

::: services/common/moz.build:38
(Diff revision 1)
> -        EXTRA_PP_JS_MODULES['services-common'] += [
> +        EXTRA_JS_MODULES['services-common'] += [

This will just go away once Bug 1237983 lands.

::: services/common/tests/unit/test_bagheera_client.js:96
(Diff revision 1)
> -add_task(function test_post_delete_multiple_obsolete_documents () {
> +add_task(function* test_post_delete_multiple_obsolete_documents () {
Attachment #8712164 - Flags: review?(rnewman) → review+
(Assignee)

Comment 3

2 years ago
Created attachment 8713487 [details] [diff] [review]
Patch, updated

(In reply to Richard Newman [:rnewman] from comment #2)
> 
> ::: services/common/moz.build:38
> (Diff revision 1)
> > -        EXTRA_PP_JS_MODULES['services-common'] += [
> > +        EXTRA_JS_MODULES['services-common'] += [
> 
> This will just go away once Bug 1237983 lands.

Rebased on top of bug 1237983, carry over r+.

Attach as a patch since reviewboard-hg is down.
Attachment #8713487 - Flags: review+

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ad188676eb21
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.