1242965 - Make services/common eslintable

Status: RESOLVED FIXED

(Cloud Services :: Firefox: Common, defect)

Comment 1

[Hector Zhao [:hectorz]]

Attachment: MozReview Request: Bug 1242965 - Make services/common eslintable. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/32449/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32449/

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8712164 [details]
MozReview Request: Bug 1242965 - Make services/common eslintable. r?rnewman

https://reviewboard.mozilla.org/r/32449/#review29243

::: services/common/async.js
(Diff revision 1)
> -#ifndef MERGED_COMPARTMENT

I guess we don't do this any more!

::: services/common/moz.build:38
(Diff revision 1)
> -        EXTRA_PP_JS_MODULES['services-common'] += [
> +        EXTRA_JS_MODULES['services-common'] += [

This will just go away once Bug 1237983 lands.

::: services/common/tests/unit/test_bagheera_client.js:96
(Diff revision 1)
> -add_task(function test_post_delete_multiple_obsolete_documents () {
> +add_task(function* test_post_delete_multiple_obsolete_documents () {

Comment 3

[Hector Zhao [:hectorz]]

Attachment: Patch, updated

(In reply to Richard Newman [:rnewman] from comment #2)
> 
> ::: services/common/moz.build:38
> (Diff revision 1)
> > -        EXTRA_PP_JS_MODULES['services-common'] += [
> > +        EXTRA_JS_MODULES['services-common'] += [
> 
> This will just go away once Bug 1237983 lands.

Rebased on top of bug 1237983, carry over r+.

Attach as a patch since reviewboard-hg is down.

Comment 4

[Hector Zhao [:hectorz]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=28310e63182c

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad188676eb21

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad188676eb21