1242967 - VR HMDs should create their own VsyncSource; widget/etc. should keep track and switch to listening to them

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

With new vsync work in bug 1184283, widget can switch which source of vsync it listens to.  It should know to switch to a HMD vsync source when the user is using a HMD.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: MozReview Request: Bug 1242967 - VR HMDs should create their own VsyncSource, and notify widget when necessary

Review commit: https://reviewboard.mozilla.org/r/32645/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32645/

Comment 2

[:kip (Kearwood Gilbert)]

Comment on attachment 8712787 [details]
MozReview Request: Bug 1242967 - VR HMDs should create their own VsyncSource, and notify widget when necessary

https://reviewboard.mozilla.org/r/32645/#review29513

This all looks good to me, thanks!

Comment 3

[:kip (Kearwood Gilbert)]

This is no longer necessary with the WebVR 1.0 implementation, as new VR hardware APIs are not vsync based.

Bug 1250244 (WebVR 1.0 Implementation) includes separate requestAnimationFrame callbacks for each VRDevice that request frames with the correct timing for the VR hardware.