1242968 - Tests in devtools/shared/acorn/test/unit/ and devtools/shared/pretty-fast/test/unit/ may fail with asynchronous termination

Status: NEW

(DevTools :: General, defect, P3)

Description

[:Paolo Amadini]

There is a listener that turns console messages into test failures in "head_acorn.js".

This doesn't generate any failure at present, but just because the listener doesn't have the time to catch the errors that occur in some tests. If we spin the event loop at the end of the test, this catches some more warnings, for example:


 0:00.41 LOG: Thread-3 ERROR head_acorn.js got console message: [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/acorn/acorn.js" line: 2329 column: 117 source: "his.exprAllowed = false;else if (update = type.updateContext) update.call(this, prevType);else this.exprAllowed = type.b"}]

 0:00.41 LOG: Thread-3 ERROR head_acorn.js got console message: [JavaScript Warning: "ReferenceError: reference to undefined property Services.appinfo.name" {file: "resource://devtools/shared/Loader.jsm" line: 462}]

This is an issue for bug 989960 where we have to spin the event loop to wait for uncaught rejections. I'm going to filter out the JavaScript warnings in bug 989960 for the moment, to allow the infrastructure change to take effect.

Comment 1

[:Paolo Amadini]

The same for "head_pretty-fast.js".

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to :Paolo Amadini from comment #0)
>  0:00.41 LOG: Thread-3 ERROR head_acorn.js got console message: [JavaScript
> Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?"
> {file: "resource://gre/modules/commonjs/toolkit/loader.js ->
> resource://devtools/acorn/acorn.js" line: 2329 column: 117 source:
> "his.exprAllowed = false;else if (update = type.updateContext)
> update.call(this, prevType);else this.exprAllowed = type.b"}]
> 
>  0:00.41 LOG: Thread-3 ERROR head_acorn.js got console message: [JavaScript
> Warning: "ReferenceError: reference to undefined property
> Services.appinfo.name" {file: "resource://devtools/shared/Loader.jsm" line:
> 462}]

Both of these "errors" are actually style warnings, and acorn is third party code. Any way we can disable these style warnings for these subdirectories?

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Style warnings? Do you mean strict warnings?

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Yes (although confusingly enough, unrelated to strict mode).

Comment 5

[Patrick Brosset <:pbro>]

DevTools bug triage (filter on CLIMBING SHOES).