Move button submit/reset code into nsHTMLInputElement

RESOLVED FIXED in mozilla0.9.9

Status

()

RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: bryner, Assigned: bryner)

Tracking

Trunk
mozilla0.9.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
As a prerequisite for implementing the HTML button control in XBL, the form
submit logic needs to be moved to nsHTMLInputElement::HandleDOMEvent(). 
Currently it resides in nsHTMLButtonControlFrame::MouseClicked().
(Assignee)

Updated

17 years ago
Blocks: 123477
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
Comment on attachment 68457 [details] [diff] [review]
patch

r=jkeiser if you just put a big fat comment in MouseClicked() saying this is
not called (and maybe where to look for the click handler)
Attachment #68457 - Flags: review+
Comment on attachment 68457 [details] [diff] [review]
patch

And remove the code from image the same way.

Comment 4

17 years ago
Comment on attachment 68457 [details] [diff] [review]
patch

sr=attinasi

Do we want to remove the same calls from the ImageControlFrame and the
TextControlFrame, and if so, the implementation from the FormControlHelper?  It
is confusing to have some elements submitting from the frames, and some from
the content element.
Attachment #68457 - Flags: superreview+
(Assignee)

Comment 5

17 years ago
I had planned to go back and do some of this sort of cleanup once XBL form
controls are turned on permanently, when the frame code is removed.
(Assignee)

Comment 6

17 years ago
checked in.  i will clean up this code after XBL form controls are turned on,
when the old form control frames are removed.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Updated

17 years ago
QA Contact: madhur → tpreston
You need to log in before you can comment on or make changes to this bug.