Closed Bug 1243096 Opened 4 years ago Closed 4 years ago

Disallow ini test manifests including only support-files and convert them to TEST_HARNESS_FILES

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file)

For bug 1242051, we'd like to be able to tell from all-tests.json what support files are needed to run a particular test. These manifests can be converted to TEST_HARNESS_FILES. As of now these include:

/home/chris/m-c/js/xpconnect/tests/xpcshell.ini
/home/chris/m-c/js/xpconnect/tests/chrome/mochitest.ini
/home/chris/m-c/dom/base/test/chrome/mochitest.ini
/home/chris/m-c/dom/media/webaudio/test/blink/mochitest.ini
/home/chris/m-c/dom/tests/mochitest/ajax/lib/mochitest.ini
/home/chris/m-c/dom/tests/mochitest/ajax/mochikit/tests/mochitest.ini
/home/chris/m-c/dom/imptests/mochitest.ini
/home/chris/m-c/layout/style/test/chrome/mochitest.ini
/home/chris/m-c/layout/style/test/css-visited/mochitest.ini
/home/chris/m-c/layout/reftests/fonts/math/mochitest.ini
/home/chris/m-c/layout/reftests/fonts/mochitest.ini
/home/chris/m-c/layout/reftests/fonts/mplus/mochitest.ini
/home/chris/m-c/docshell/test/chrome/mochitest.ini
/home/chris/m-c/toolkit/components/jsdownloads/test/data/xpcshell.ini
/home/chris/m-c/toolkit/components/places/tests/xpcshell.ini
/home/chris/m-c/toolkit/components/places/tests/browser/mochitest.ini
/home/chris/m-c/toolkit/components/places/tests/chrome/mochitest.ini
/home/chris/m-c/toolkit/components/places/tests/mochitest.ini
/home/chris/m-c/toolkit/components/places/tests/mochitest/bug_411966/mochitest.ini
/home/chris/m-c/toolkit/components/places/tests/mochitest/bug_461710/mochitest.ini
/home/chris/m-c/devtools/client/framework/test/xpcshell.ini
/home/chris/m-c/devtools/client/promisedebugger/test/browser.ini
/home/chris/m-c/devtools/shared/apps/tests/data/mochitest.ini
/home/chris/m-c/testing/mochitest/dynamic/mochitest.ini
/home/chris/m-c/testing/mochitest/MochiKit/mochitest.ini
/home/chris/m-c/testing/mochitest/static/mochitest.ini
/home/chris/m-c/testing/mochitest/tests/MochiKit-1.4.2/MochiKit/mochitest.ini
Comment on attachment 8712549 [details]
MozReview Request: Bug 1243096 - Remove ini manifests containing only support-files and move their contents to TEST_HARNESS_FILES. r=gps

https://reviewboard.mozilla.org/r/32577/#review29521

Nice.

I view test manifests as a natural extension of moz.build files, so I have no qualms about moving things from manifests to moz.build files where there isn't a compelling reason for it to existing in test manifests. Support files definitely qualifies, as that feature existed before moz.build. I'd be in favor of moving *all* of support-files to moz.build. But that is scope creep.
Attachment #8712549 - Flags: review?(gps) → review+
Assignee: nobody → cmanchester
https://hg.mozilla.org/mozilla-central/rev/ab448c9b8165
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.