1243295 - TypeError: searchbar.inputChanged is not a function from UITour.jsm running browser_UITour3.js

Status: RESOLVED FIXED

(Firefox :: Tours, defect)

Description

[Matthew N. [:MattN]]

A coding exception was thrown in a Promise resolution callback.
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
Full message: TypeError: searchbar.inputChanged is not a function
Full stack: this.UITour.onPageEvent/<@resource:///modules/UITour.jsm:664:11
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:933:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:812:7
Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:743:11
this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:775:7
Promise.prototype.then@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:450:5
this.UITour.getTarget@resource:///modules/UITour.jsm:959:5
this.UITour.onPageEvent@resource:///modules/UITour.jsm:660:29

Florian, do you know the story behind this? It seems like the implementation of setSearchTerm is stale. Can we fix it or remove it?

Comment 1

[Florian Quèze [:florian]]

(In reply to Matthew N. [:MattN] from comment #0)

> Florian, do you know the story behind this? It seems like the implementation
> of setSearchTerm is stale. Can we fix it or remove it?

I don't know if/how setSearchTerm is/was used, unfortunately. But the JS error you report looks like my mistake: http://hg.mozilla.org/mozilla-central/diff/43d39d5f35b2/browser/components/search/content/search.xml#l1.264

Comment 2

[Florian Quèze [:florian]]

Attachment: Fix

Comment 3

[Matthew N. [:MattN]]

I also removed the catch with Cu.reportError so the test would have failed when this bug got instroduced.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b705b2fab063

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b705b2fab063