Closed Bug 1243312 Opened 4 years ago Closed 4 years ago

Missing include nsNetCID.h

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox45 --- wontfix
firefox46 --- wontfix
firefox47 --- fixed
firefox-esr45 --- fixed

People

(Reporter: dragana, Assigned: dragana)

References

Details

(Keywords: regression)

Attachments

(1 file)

With bug 905127 we un-inlining nsNetUtil.h.

I got a private e-mail informing that a build does not work if ac_add_options --enable-libproxy is set.

The error is:
.../firefox-43.0.3/toolkit/system/unixproxy/nsLibProxySettings.cpp: At global scope:
.../firefox-43.0.3/toolkit/system/unixproxy/nsLibProxySettings.cpp:129:5: error: 'NS_SYSTEMPROXYSETTINGS_CONTRACTID' was not declared in this scope
   { NS_SYSTEMPROXYSETTINGS_CONTRACTID, &kNS_UNIXSYSTEMPROXYSERVICE_CID },

So nsNetCID.h is missing
Attachment #8712586 - Flags: review?(jduell.mcbugs)
Attachment #8712586 - Flags: review?(jduell.mcbugs) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/23226470bb94
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment on attachment 8712586 [details] [diff] [review]
bug_1243312.patch

[Approval Request Comment]
ESR consideration: Easier debugging downstream
User impact if declined: Broken build with --enable-libproxy
Fix Landed on Version: Firefox 47
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: None
Attachment #8712586 - Flags: approval-mozilla-esr45?
Keywords: regression
Comment on attachment 8712586 [details] [diff] [review]
bug_1243312.patch

Simplify the life of packagers, taking it.
Attachment #8712586 - Flags: approval-mozilla-esr45? → approval-mozilla-esr45+
You need to log in before you can comment on or make changes to this bug.