1243317 - browser_UITour_defaultBrowser.js isn't testing anything but would fail on OS X

Status: RESOLVED DUPLICATE of bug 1240892

(Firefox :: Tours, defect)

Description

[Matthew N. [:MattN]]

WHile making this test work with e10s it began to fail because the test was never waiting for the result before. The problem is that one should either use taskift or the done argument but they shouldn't be mixed since taskify implies you're using a task and so the `done` method will be called automatically then the task is done. Since none of the Task functions yielded anything, the result of the async operation results weren't checked.

Jared, the tests fail on my OS X machine now but I'm not sure what the expected results are. Can you build on top of my patch which waits for the checks and fix it so it will pass on all platforms?

Thanks

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1243317 -

Review commit: https://reviewboard.mozilla.org/r/32585/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32585/

Comment 2

[Matthew N. [:MattN]]

55 INFO TEST-UNEXPECTED-FAIL | browser/components/uitour/test/browser_UITour_defaultBrowser.js | canSetDefaultBrowserInBackground should be true when a hash is present - Got true, expected false
Stack trace:
    chrome://mochikit/content/browser-test.js:test_is:979
    chrome://mochitests/content/browser/browser/components/uitour/test/browser_UITour_defaultBrowser.js:test_setInBackgroundWhenPrefExists:67
    add_UITour_task/genFun/</</<@chrome://mochitests/content/browser/browser/components/uitour/test/head.js:385:29
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:735:59

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

test_setInBackgroundWhenPrefExists and test_setInBackgroundWhenPrefDoesntExist are being removed by bug 1240892, which already landed on mozilla-release and should land on mozilla-central very soon (aurora to follow).

Comment 4

[Matthew N. [:MattN]]

I'll move the e10s patch to bug 1073247.