Closed
Bug 1243318
Opened 10 years ago
Closed 10 years ago
[mozfile] extract_zip() should not set file permissions if there are no attributes available
Categories
(Testing :: Mozbase, defect)
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
|
3.64 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
With the problem as seen on bug 1242592 the mozfile.extract_zip() method currently fails, because the test zip files as created with JarWriter under Windows do not contain permissions to be used for any files on Linux and OS X. As result updating the file permissions with 0 means no access at all.
Given that file permissions with no-one having rights for anything don't make sense, we should better not update them in those cases. It might actually be a bug in JarWriter but personally I think we should guard against it.
|
Assignee | |
Updated•10 years ago
|
Summary: [mozfile] extract_zip() should not set file permissions if there are none → [mozfile] extract_zip() should not set file permissions if there are no attributes available
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8712632 [details] [diff] [review]
fix permissions v1
Review of attachment 8712632 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for digging into this!
Attachment #8712632 -
Flags: review?(ahalberstadt) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
|
Assignee | |
Updated•10 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•