1243530 - Make it possible to disable Autoland without removing repository urls from config

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

I clicked the "See it in Mercurial" link at https://reviewboard.mozilla.org/r/10633/diff/5 but there was no joy.  Instead there was a 404 page that tried to give me the login runaround.

There should either be joy or no link.  Joyless links are joykillers.

Comment 1

[:Gijs (he/him)]

FWIW, this used to be a link to this old-style autoland trypush: https://hg.mozilla.org/try/rev/d2387f57bb8d

where the treeherder results seem to have gone AWOL, which might be related? Even so, the busted link is very busted.

Comment 2

[Gregory Szorc [:gps]]

Looks like the autoland state of that one got messed up somehow (notice it doesn't say where it landed). That's probably root cause.

Comment 3

[Steven MacLeod [:smacleod]]

(In reply to Gregory Szorc [:gps] from comment #2)
> Looks like the autoland state of that one got messed up somehow (notice it
> doesn't say where it landed). That's probably root cause.

This is because we disabled autoland by removing the autoland url. These links are generated by using that to decide which tree. If we re-enabled autoland all the links would start working again (what we need to do though is just add an option to disable without removing the url)

Comment 4

[Dan Minor [:dminor]]

Morphing this bug to add a state flag rather than relying upon the repository URLs.

Comment 5

[Boris Zbarsky [:bzbarsky]]

So what I was _trying_ to do was get at the actual relevant Mercurial changesets.  I saw a link labeled "See it in Mercurial" and clicked on it.

It sounds like the link text should be "See the try run for this patch set" or something, no?

Comment 6

[Mauro Doglio [:mdoglio]]

:bz under normal circumstances you get both a link to mercurial and a link to treeherder. This bug will fix that as well.

Comment 7

[Dan Minor [:dminor]]

Attachment: MozReview Request: mozreview: add fields to disable autoland in custom hosting service (bug 1243530) r?mdoglio

Review commit: https://reviewboard.mozilla.org/r/35103/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35103/

Comment 8

[Dan Minor [:dminor]]

Attachment: MozReview Request: mozreview: reject autoland requests for disabled repositories (bug 1243530) r?mdoglio

Review commit: https://reviewboard.mozilla.org/r/35105/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35105/

Comment 9

[Dan Minor [:dminor]]

Attachment: MozReview Request: mozreview: use new hostingservice fields to disable autoland in UI (bug 1243530) r?mdoglio

Review commit: https://reviewboard.mozilla.org/r/35107/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35107/

Comment 10

[Dan Minor [:dminor]]

Attachment: MozReview Request: mozreview: make autoland selenium tests check autoland button title (bug 1243530) r?mdoglio

Right now we check the opacity of the autoland button to see if it is
enabled. If we check the title instead we'll get better errors when
something goes wrong.

Review commit: https://reviewboard.mozilla.org/r/35109/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35109/

Comment 11

[Mauro Doglio [:mdoglio]]

Comment on attachment 8719770 [details]
MozReview Request: mozreview: add fields to disable autoland in custom hosting service (bug 1243530) r?mdoglio

https://reviewboard.mozilla.org/r/35103/#review32081

Comment 12

[Mauro Doglio [:mdoglio]]

Comment on attachment 8719771 [details]
MozReview Request: mozreview: reject autoland requests for disabled repositories (bug 1243530) r?mdoglio

https://reviewboard.mozilla.org/r/35105/#review32085

Comment 13

[Mauro Doglio [:mdoglio]]

Comment on attachment 8719772 [details]
MozReview Request: mozreview: use new hostingservice fields to disable autoland in UI (bug 1243530) r?mdoglio

https://reviewboard.mozilla.org/r/35107/#review32087

::: testing/vcttesting/unittest.py:18
(Diff revision 1)
> +from selenium.common.exceptions import ElementNotVisibleException

is this supposed to go in another commit?

Comment 14

[Mauro Doglio [:mdoglio]]

Comment on attachment 8719773 [details]
MozReview Request: mozreview: make autoland selenium tests check autoland button title (bug 1243530) r?mdoglio

https://reviewboard.mozilla.org/r/35109/#review32095

::: pylib/mozreview/mozreview/static/mozreview/js/autoland.js:268
(Diff revision 1)
> -    try_trigger.attr('title', 'You can not autoland from a closed review request');
> +    autoland_trigger.attr('title', 'You can not autoland from a closed review request');

I guess this is fixing a separate issue?

Comment 15

[Dan Minor [:dminor]]

Attachment: MozReview Request: testing: fix missing import in unittest.py (bug 1243530) r?mdoglio

Review commit: https://reviewboard.mozilla.org/r/35457/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35457/

Comment 16

[Dan Minor [:dminor]]

Comment on attachment 8719772 [details]
MozReview Request: mozreview: use new hostingservice fields to disable autoland in UI (bug 1243530) r?mdoglio

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35107/diff/1-2/

Comment 17

[Dan Minor [:dminor]]

Attachment: MozReview Request: mozreview: fix title for autoland button on discarded review (bug 1243530) r?mdoglio

Review commit: https://reviewboard.mozilla.org/r/35459/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35459/

Comment 18

[Dan Minor [:dminor]]

Comment on attachment 8719773 [details]
MozReview Request: mozreview: make autoland selenium tests check autoland button title (bug 1243530) r?mdoglio

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35109/diff/1-2/

Comment 19

[Mauro Doglio [:mdoglio]]

Comment on attachment 8720775 [details]
MozReview Request: mozreview: fix title for autoland button on discarded review (bug 1243530) r?mdoglio

https://reviewboard.mozilla.org/r/35459/#review32101

Comment 20

[Mauro Doglio [:mdoglio]]

Comment on attachment 8720774 [details]
MozReview Request: testing: fix missing import in unittest.py (bug 1243530) r?mdoglio

https://reviewboard.mozilla.org/r/35457/#review32103