Closed Bug 1243530 Opened 5 years ago Closed 5 years ago

Make it possible to disable Autoland without removing repository urls from config

Categories

(MozReview Graveyard :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: dminor)

Details

Attachments

(6 files)

I clicked the "See it in Mercurial" link at https://reviewboard.mozilla.org/r/10633/diff/5 but there was no joy.  Instead there was a 404 page that tried to give me the login runaround.

There should either be joy or no link.  Joyless links are joykillers.
FWIW, this used to be a link to this old-style autoland trypush: https://hg.mozilla.org/try/rev/d2387f57bb8d

where the treeherder results seem to have gone AWOL, which might be related? Even so, the busted link is very busted.
Looks like the autoland state of that one got messed up somehow (notice it doesn't say where it landed). That's probably root cause.
(In reply to Gregory Szorc [:gps] from comment #2)
> Looks like the autoland state of that one got messed up somehow (notice it
> doesn't say where it landed). That's probably root cause.

This is because we disabled autoland by removing the autoland url. These links are generated by using that to decide which tree. If we re-enabled autoland all the links would start working again (what we need to do though is just add an option to disable without removing the url)
Morphing this bug to add a state flag rather than relying upon the repository URLs.
Assignee: nobody → dminor
Priority: -- → P1
Summary: The "See it in Mercurial" link does nothing of the sort → Make it possible to disable Autoland without removing repository urls from config
So what I was _trying_ to do was get at the actual relevant Mercurial changesets.  I saw a link labeled "See it in Mercurial" and clicked on it.

It sounds like the link text should be "See the try run for this patch set" or something, no?
:bz under normal circumstances you get both a link to mercurial and a link to treeherder. This bug will fix that as well.
Right now we check the opacity of the autoland button to see if it is
enabled. If we check the title instead we'll get better errors when
something goes wrong.

Review commit: https://reviewboard.mozilla.org/r/35109/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35109/
Attachment #8719773 - Flags: review?(mdoglio)
Comment on attachment 8719770 [details]
MozReview Request: mozreview: add fields to disable autoland in custom hosting service (bug 1243530) r?mdoglio

https://reviewboard.mozilla.org/r/35103/#review32081
Attachment #8719770 - Flags: review?(mdoglio) → review+
Comment on attachment 8719771 [details]
MozReview Request: mozreview: reject autoland requests for disabled repositories (bug 1243530) r?mdoglio

https://reviewboard.mozilla.org/r/35105/#review32085
Attachment #8719771 - Flags: review?(mdoglio) → review+
Comment on attachment 8719772 [details]
MozReview Request: mozreview: use new hostingservice fields to disable autoland in UI (bug 1243530) r?mdoglio

https://reviewboard.mozilla.org/r/35107/#review32087

::: testing/vcttesting/unittest.py:18
(Diff revision 1)
> +from selenium.common.exceptions import ElementNotVisibleException

is this supposed to go in another commit?
Attachment #8719772 - Flags: review?(mdoglio) → review+
Comment on attachment 8719773 [details]
MozReview Request: mozreview: make autoland selenium tests check autoland button title (bug 1243530) r?mdoglio

https://reviewboard.mozilla.org/r/35109/#review32095

::: pylib/mozreview/mozreview/static/mozreview/js/autoland.js:268
(Diff revision 1)
> -    try_trigger.attr('title', 'You can not autoland from a closed review request');
> +    autoland_trigger.attr('title', 'You can not autoland from a closed review request');

I guess this is fixing a separate issue?
Attachment #8719773 - Flags: review?(mdoglio) → review+
Comment on attachment 8719772 [details]
MozReview Request: mozreview: use new hostingservice fields to disable autoland in UI (bug 1243530) r?mdoglio

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35107/diff/1-2/
Comment on attachment 8719773 [details]
MozReview Request: mozreview: make autoland selenium tests check autoland button title (bug 1243530) r?mdoglio

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35109/diff/1-2/
Comment on attachment 8720775 [details]
MozReview Request: mozreview: fix title for autoland button on discarded review (bug 1243530) r?mdoglio

https://reviewboard.mozilla.org/r/35459/#review32101
Attachment #8720775 - Flags: review?(mdoglio) → review+
Attachment #8720774 - Flags: review?(mdoglio) → review+
Comment on attachment 8720774 [details]
MozReview Request: testing: fix missing import in unittest.py (bug 1243530) r?mdoglio

https://reviewboard.mozilla.org/r/35457/#review32103
Product: Developer Services → MozReview
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.