Closed Bug 1243542 Opened 8 years ago Closed 8 years ago

Ensure consistent text selection handles everywhere

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

defect
Not set
normal

Tracking

(firefox47 affected, firefox48 fixed, fennec48+)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox47 --- affected
firefox48 --- fixed
fennec 48+ ---

People

(Reporter: ahunt, Assigned: capella)

References

Details

Attachments

(1 file)

In Bug 1097398 we'll ensure that the gecko native text selection looks like native Android, however the locationbar still uses the old rectangular Android (4.0?) text selection handles. We should switch that to use normal Android selection handles.

We should also make sure all other selection handles are correct - however most other places I've tested all show modern rounded Android selection handles (which are orange), so I suspect it's only the locationbar that needs updating.

(E.g. Settings->General->Home->Set a Homepage->custom uses modern selection handles.)
Depends on: 1097398
(In reply to Andrzej Hunt :ahunt from comment #0)
> In Bug 1097398 we'll ensure that the gecko native text selection looks like
> native Android, however the locationbar still uses the old rectangular
> Android (4.0?) text selection handles. We should switch that to use normal
> Android selection handles.
> 
> We should also make sure all other selection handles are correct - however
> most other places I've tested all show modern rounded Android selection
> handles (which are orange), so I suspect it's only the locationbar that
> needs updating.

That's great news! I wonder why the location bar is different. It's definitely the most noticable input box in our app, so I feel like we should make sure it looks good.
Flags: needinfo?(alam)
Agree - they should all be the same. 

This also seems to me like it's related to bug 1240917 ?
Flags: needinfo?(alam)
(In reply to Anthony Lam (:antlam) from comment #2)
> Agree - they should all be the same. 
> 
> This also seems to me like it's related to bug 1240917 ?

That bug is about the action bar that appears for text selection in web content, and this bug is about updating the handles in native UI. So I don't think that will affect this bug.
Do we need to wait on bug 1097398 to have resources for updating these handle images? Or is this something we could work on in parallel? I think this would be a really nice improvement for the urlbar.
Flags: needinfo?(markcapella)
This sounds great! The URL bar should be the only thing using the old resources now, unless a nightly user opts out of |layout.accessiblecaret.enabled| which we currently support, then he'll see those old ones still.

Simply changing the TextSelection android:src drawables shouldn't impact the new "blue-balls" selection resources, which currently are the delivered FFOS versions, and will be replace locally to Android by bug 1097398 to be the new "orange pointy-balls" [0]

I'd imagine we'd want to coordinate testing of both this and that bug, as there was uncertainty in my mind as to the asset design as attached in bug 1097398, pertinent discussion picks up around [1].

Basically FFOS provides a deal of empty space surrounding the carets to facilitate touch-ability ... our new version wraps-content (so to speak) so resource size varies. As a result, one of the last changes I provided was to programmatically scale our new versions to appear visually correct in the same amount of space.


[0] https://www.dropbox.com/s/xct6i22y7s0b1v2/bug_1097398_new.png?dl=0&preview=bug_1097398_new.png
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1097398#c64
Flags: needinfo?(markcapella)
Attached patch bug1243542.diffSplinter Review
This is a quick update of the resources we use to override Androids Selection handles, to match the new versions developed for AccessibleCarets in bug 1097398.

Replaces the pointy handles in the UrlBar, and also where anyone is using the deprecated TextSelection/SelectionHandler methods (reset |layout.accessiblecaret.enabled| to false).

This patch can ride the trains independent of AccessibleCarets as a result, and any slippage of the target v48 there shouldn't matter
Attachment #8733464 - Flags: review?(margaret.leibovic)
Nice! Thanks for picking this up. This looks good to me, just want to make sure antlam gives this a thumbs up before we land it.
Flags: needinfo?(alam)
Attachment #8733464 - Flags: review?(margaret.leibovic) → review+
Assignee: nobody → markcapella
tracking-fennec: --- → 48+
nice!
Flags: needinfo?(alam)
https://hg.mozilla.org/mozilla-central/rev/2af30898a2a8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
This is nice!
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.