Closed Bug 1243610 Opened 4 years ago Closed 4 years ago

Refactor UpdateOverflow to separate out local overflow from descendants

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox47 --- affected
firefox49 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

This was initially discussed in bug 1198135 comment 9.

To correctly compute the overflow areas of preserve-3d children, we need to do custom processing of the descendants.

To do this we want to split UpdateOverflow into two pieces, one that computes the overflow for the frame itself, and one that accumulates the overflow areas of children.
Depends on: 1243614
Attachment #8737011 - Flags: review?(dbaron)
One thing I noticed is that nsBlockFrame::UpdateOverflow (now nsBlockFrame::UnionChildOverflow) has special handing for line children.

I suspect this means that RecomputePreserve3DChildrenOverflow is potentially incorrect for block frames since it just walks the child lists instead.

I don't really understand the lines code, so I'm not sure why we need to do this.

I think the best fix (as a follow-up) would be to make nsIFrame::UnionChildOverflow (along with nsLayoutUtils::UnionChildOverflow) 'preserve-3d aware' and then have RecomputePreserve3DChildrenOverflow use that instead of having it's own implementation of unioning child overflow areas.

This is an existing bug (not affected by these changes), but still something we'd want to fix before bug 1198135.
Comment on attachment 8737011 [details] [diff] [review]
Split UpdateOverflow

It would have been nice to have the refactoring of GetLayoutFlags
in a separate patch underneath.

Given that you're promoting GetLayoutFlags from nsBox to nsIFrame,
please rename it to GetXULLayoutFlags, and put it in the part of
the nsIFrame.h header with the other XUL methods, rather than
next to the overflow methods.  (Search for "GetXUL"; you'll find a
whole bunch together.)

Please remove the:
   // XXX Maybe these three should be a separate interface?
right above UpdateOverflow in nsIFrame.h.  Looking at the changeset
where it was added:
https://github.com/mozilla/gecko-dev/commit/a12c3d6c5d1fa18ef018f40a2738bc2e8295416b
it's not clear if the comment referred to the 3 before the comment or
the three after, but either way, we don't want to do it and the comment
has become very unclear.

I'm not convinced that DidUpdateOverflow and ComputeCustomOverflow need
to be two separate things.  Why can't the callbacks just happen in
ComputeCustomOverflow?  (In the case of ScrollFrameHelper, after it
returns false.)  I'm OK with fixing that in a followup bug if you think
it's risky, though.

I also think that it's not OK to skip DidUpdateOverflow if
FinishAndStoreOverflow returns false, since a number of the things in
DidUpdateOverflow callbacks are about things that need to be cleared
when overflow of children change.

I think it's also probably cleaner for all of the derived
ComputeCustomOverflow and (if it stays) DidUpdateOverflow methods to end
with a call to the base class method.  Otherwise things seem risky for
future introductions of new overrides.


r=dbaron with those changes

Sorry for the massive delay getting to this.
Attachment #8737011 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/35b6bedcbb2e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.