The variable `promptCount` (from bug 1225648) is defined in an #ifndef RELEASE_BUILD block, but used outside of it. Now that the code has merged to beta, it's throwing and stopping the rest of the function to work. Incidentally, this was just fixed yesterday with the removal of preprocessing from this file (bug 1241993). But we should just use a simpler fix here to be able to uplift it to beta. [Tracking Requested - why for this release]: Telemetry about Firefox being the default browser, and some code related to e10s accessibility, are prevented to run due to this.
Created attachment 8712984 [details] [diff] [review] patch
Ugh, sorry for missing this in review. :-(
Comment on attachment 8712984 [details] [diff] [review] patch This has been fixed differently on central, so it needs to go straight to aurora/beta Approval Request Comment [Feature/regressing bug #]: undefined variable name [User impact if declined]: BROWSER_IS_USER_DEFAULT telemetry probe and e10s accessibility warning missing [Describe test coverage new/current, TreeHerder]: built locally [Risks and why]: very simple patch, just moves a variable declaration [String/UUID change made/needed]: none
Comment on attachment 8712984 [details] [diff] [review] patch Fix a warning, taking it.
The other fix (bug 1241993) made it to aurora, so this only affected beta. https://hg.mozilla.org/releases/mozilla-beta/rev/1241ef0ab5da