Note: There are a few cases of duplicates in user autocompletion which are being worked on.

"promptCount is undefined" on beta (nsBrowserGlue.js)

RESOLVED FIXED in Firefox 45

Status

()

Firefox
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

45 Branch
Firefox 45
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10sm8+, firefox45+ fixed, firefox46+ unaffected, firefox47 unaffected)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The variable `promptCount` (from bug 1225648) is defined in an #ifndef RELEASE_BUILD block, but used outside of it. Now that the code has merged to beta, it's throwing and stopping the rest of the function to work.

Incidentally, this was just fixed yesterday with the removal of preprocessing from this file (bug 1241993). But we should just use a simpler fix here to be able to uplift it to beta.


[Tracking Requested - why for this release]:
Telemetry about Firefox being the default browser, and some code related to e10s accessibility, are prevented to run due to this.
(Assignee)

Comment 1

2 years ago
Created attachment 8712984 [details] [diff] [review]
patch
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Attachment #8712984 - Flags: review?(jaws)
(Assignee)

Updated

2 years ago
tracking-e10s: --- → ?
Attachment #8712984 - Flags: review?(jaws) → review+

Comment 2

2 years ago
Ugh, sorry for missing this in review. :-(
(Assignee)

Comment 3

2 years ago
Comment on attachment 8712984 [details] [diff] [review]
patch

This has been fixed differently on central, so it needs to go straight to aurora/beta

Approval Request Comment
[Feature/regressing bug #]: undefined variable name
[User impact if declined]: BROWSER_IS_USER_DEFAULT telemetry probe and e10s accessibility warning missing
[Describe test coverage new/current, TreeHerder]: built locally
[Risks and why]: very simple patch, just moves a variable declaration
[String/UUID change made/needed]: none
Attachment #8712984 - Flags: approval-mozilla-beta?
Attachment #8712984 - Flags: approval-mozilla-aurora?
tracking-firefox45: ? → +
tracking-firefox46: ? → +
Comment on attachment 8712984 [details] [diff] [review]
patch

Fix a warning, taking it.
Attachment #8712984 - Flags: approval-mozilla-beta?
Attachment #8712984 - Flags: approval-mozilla-beta+
Attachment #8712984 - Flags: approval-mozilla-aurora?
Attachment #8712984 - Flags: approval-mozilla-aurora+
tracking-e10s: ? → m8+
(Assignee)

Comment 5

2 years ago
The other fix (bug 1241993) made it to aurora, so this only affected beta.

https://hg.mozilla.org/releases/mozilla-beta/rev/1241ef0ab5da
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox45: affected → fixed
status-firefox46: affected → unaffected
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
status-firefox47: --- → unaffected
Attachment #8712984 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.