Closed Bug 1243625 Opened 10 years ago Closed 10 years ago

Extension FireGestures's some features fails after bug 1233497 and with Tab Mix Plus & Tree Style Tab

Categories

(Firefox :: Extension Compatibility, defect)

Product:
Firefox
Component:
Extension Compatibility
Version:
47 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
e10s + ---

People

(Reporter: Fanolian+BMO, Unassigned)

References

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0 Build ID: 20160127030236 Steps to reproduce: 1. Install Firegesture 1.10.3: https://addons.mozilla.org/en-US/firefox/addon/firegestures/versions/ 2. Assign gestures to Scroll to Top/Bottom. 3. Draw the gestures Actual results: The gestures fail. Error is Gesture failed: (Error: Unsafe CPOW usage forbidden). A similar warning appears in browser console as well. I don't use many gestures so there are perhaps more functions are blocked by the issue. Workaround: Toggling dom.ipc.cpows.forbid-unsafe-from-browser fixes the issue. Extension author is notified via https://github.com/gomita/firegestures/issues/116
Blocks: 1233497
Has STR: --- → yes
Component: Untriaged → General
Keywords: regression
I thought this wasn't supposed to be applied to add-ons? Or is this an add-on triggering unsafe CPOW usage in our own code?
Component: General → Extension Compatibility
Flags: needinfo?(mconley)
Despite my best efforts, I cannot reproduce this. Here's a screencast of me trying. What am I doing wrong?: http://screencast.com/t/QmZNUZ8gwG
Flags: needinfo?(mconley) → needinfo?(Fanolian+bugzilla)
I thought the bug is obvious and didn't test it thoroughly. Sorry about that. The issue requires the combination of 3 extensions: 1. Firegesture 1.10.3: https://addons.mozilla.org/en-US/firefox/addon/firegestures/versions/ 2. Tab Mix Plus Version 0.4.2.1pre.160124a1: https://addons.mozilla.org/en-US/firefox/addon/tab-mix-plus/versions/ 3. Tree Style Tab 0.16.2015122501: https://addons.mozilla.org/en-US/firefox/addon/tree-style-tab/versions/ (Or Tree Style Tab nightly: https://piro.sakura.ne.jp/xul/xpi/nightly/ ; Require xpinstall.signatures.required;false) Install all 3 in a new profile, keep all in default settings, and I can reproduce the issue. Disabling either TMP or TST does not trigger the unsafe CPOW usage forbidden warning. I'm trying to reduce the issue into 2 extensions by changing the extensions' settings but in vain.
Flags: needinfo?(Fanolian+bugzilla)
I see the problem with comment 3. I see the other built-in features also fail due to the same reason in this case.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
See Also: → https://github.com/gomita/firegestures/issues/116
Summary: Extension FireGestures' scroll to top/bottom feature fails due to bug 1233497 → Extension FireGestures's some features fails after bug 1233497 and with Tab Mix Plus & Tree Style Tab
This is to confirm that issue can still be duplicated on the latest nightly build using steps specified in comment #3. Tested on: Version 48.0a1 Build ID 20160315030230
Sticking this up for e10s triage based on the last few comments.
tracking-e10s: --- → ?
firegestures@xuldev.org\chrome\content\firegestures\browser.js line 297 call this.sourceNode.ownerDocument.defaultView.focus() i think that this.sourceNode.ownerDocument.defaultView is unsafe CPOW replacing this with window.focus() solve the problem firegestures try to access this.sourceNode.ownerDocument in many places
The issue is fixed by the latest nightly build of Tree Style Tab (0.17.2016031800a192017). More info here: https://github.com/piroor/treestyletab/issues/1093
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.