1243731 - Hide "Download updates automatically" setting on builds from the Play Store

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[:Margaret Leibovic]

I noticed in UI telemetry that a lot of our beta/release users are hitting the "app.update.autodownload" pref, but we don't actually control downloading updates ourselves.

I thought we hid this for builds where we don't release our own updates, but it turns out hiding this pref is keyed on the AppConstants.MOZ_UPDATER flag:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java#731

And we do still build the updater with beta/release builds.

We should hide this if we're not serving updates ourselves. This is misleading users.

Comment 1

[Nick Alexander :nalexander [he/him]]

There are two things I see here:

1) we have Bug 1220773 open to provide code to determine if we're installed from an App Store; we could use it here.

2) the updater is currently enabled but not served updates on Release and Beta, see https://bugzilla.mozilla.org/show_bug.cgi?id=1232798#c6.  I'd like to actually disable the updater on Release and Beta, but the potential for bustage is very high.

I don't see tracking this for a specific release unless it begins to block other updater functionality.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.