1243753 - Hand tool not displayed while hovering over Sign in to Sync from Sync tabs panel

Status: RESOLVED WONTFIX

(Firefox :: Sync, defect)

Description

[Bogdan Maris, Desktop Test Engineering]

Affected builds:
- Firefox 45beta1
- latest Developer Edition 46.0a2
- latest Nightly 47.0a1

Affected OS's:
- Windows 10 64bit
- Mac OS X 10.10.5
- Ubuntu 14.04 32bit

STR:
1. Start firefox
2. Click Synced Tabs (reproduces from panel/menu/toolbar)
3. Hover with the cursor over Sign in to Sync

Expected: The hand tool is displayed just like in Pocket, Hello, Forget panels.

Actual results: Normal cursor is displayed.

Notes:
- This is not a recent regression, it reproduces back in Nightly from 2015-12-04 where this feature was enabled by default.

Comment 1

[Lawrence Mandel [:lmandel] (use needinfo)]

This looks like a polish issue that hasn't yet shipped. Not a show stopper but better to correct before the feature is released.

Dolske - Can you help find an owner?

Comment 2

[Justin Dolske [:Dolske]]

Feels like a followup fix for Mark, since he did the original?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

I'm not sure this is what we want - the "Sign in to Sync" element is a button (not a link), so the normal cursor seems correct. This is the same as when the button is shown in Sync Prefs - the signin button doesn't get a different cursor. Note that the links (eg, to download Firefox for IOS/Android) *do* get the cursor.

In short, my understanding is that buttons get the normal cursor (all buttons - both toolbar buttons and buttons inside panels), while links get the hand cursor, so I think this is WONTFIX - but delegating to rfeeley for the final say.

(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #0)
> Expected: The hand tool is displayed just like in Pocket, Hello, Forget
> panels.

If I click the "Forget" button I can't see the hand cursor for any element, including the main button.

If I click the Hello button in an e10s window I get a message that it doesn't work with e10s then a button allowing me to open a new window - this also doesn't get the hand cursor. Once I do open a new non-e10s window the button there *does* get a hand - so Hello isn't consistent.

Comment 4

[Ryan Feeley [:rfeeley]]

Mark is right, the hand cursor is likely an artifact of them being web content. This is not the way other buttons and links work elsewhere in the browser. I'll check with Shorlander to see if he thinks we should change Pocket/Hello to match, but I think we can close this.

Comment 5

[Ryan Feeley [:rfeeley]]

(i meant "only links")