1243805 - Replace Proxy.create with new Proxy in devtools l10n code

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Tom S [:evilpie]]

We want to remove Proxy.create as soon as possible. Devtools seems to have two uses across two duplicate files.

devtools/shared/gcli/source/lib/gcli/util/l10n.js
74:exports.propertyLookup = Proxy.create({

devtools/shared/gcli/source/lib/gcli/l10n.js
50:exports.propertyLookup = Proxy.create({

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:jwalker, I believe you are the owner of this part according to the whoseis tool.

Can you look into this and / or redirect to someone to do so?

Comment 2

[Joe Walker [:jwalker]]

I have a fix. Need to get it in. I hope this week.

Comment 3

[Joe Walker [:jwalker]]

Attachment: MozReview Request: Bug 1243805 - Replace Proxy.create with new Proxy in devtools l10n code. r=jryans

Review commit: https://reviewboard.mozilla.org/r/33887/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33887/

Comment 4

[Joe Walker [:jwalker]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cbfe6d4d77c9

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8716631 [details]
MozReview Request: Bug 1243805 - Replace Proxy.create with new Proxy in devtools l10n code. r=jryans

https://reviewboard.mozilla.org/r/33887/#review30583

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d07600bebb44

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d07600bebb44