[EME] Null check mKeys in CDMProxy::OnExpirationChange()

RESOLVED FIXED in Firefox 47

Status

()

P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 1 bug)

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
All the methods in CDMProxy except CDMProxy::OnExpirationChange() that use mKeys null check mKeys before using it because it can go away during shutdown before the IPC message to call the methods have had a chance to run.

We should do the null check in CDMProxy::OnExpirationChange() too.
(Assignee)

Comment 1

3 years ago
Created attachment 8713342 [details] [diff] [review]
Null check CDMProxy::mKeys in CDMProxy::OnExpirationChange() before use

All the methods in CDMProxy except CDMProxy::OnExpirationChange() that use
mKeys null check mKeys before using it because it can go away during shutdown
before the IPC message to call the methods have had a chance to run.

We should do the null check in CDMProxy::OnExpirationChange() too.
Attachment #8713342 - Flags: review?(jwwang)
Attachment #8713342 - Flags: review?(jwwang) → review+
Priority: -- → P1
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/633d74f817b253cc9b424de664bfa23911fa8c03
Bug 1243878 - Null check CDMProxy::mKeys in CDMProxy::OnExpirationChange() before use. r=jwwang

Comment 3

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/633d74f817b2
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.