Closed
Bug 1243878
Opened 8 years ago
Closed 8 years ago
[EME] Null check mKeys in CDMProxy::OnExpirationChange()
Categories
(Core :: Audio/Video: Playback, defect, P1)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
jwwang
:
review+
|
Details | Diff | Splinter Review |
All the methods in CDMProxy except CDMProxy::OnExpirationChange() that use mKeys null check mKeys before using it because it can go away during shutdown before the IPC message to call the methods have had a chance to run. We should do the null check in CDMProxy::OnExpirationChange() too.
|
Assignee | |
Comment 1•8 years ago
|
||
All the methods in CDMProxy except CDMProxy::OnExpirationChange() that use mKeys null check mKeys before using it because it can go away during shutdown before the IPC message to call the methods have had a chance to run. We should do the null check in CDMProxy::OnExpirationChange() too.
Attachment #8713342 -
Flags: review?(jwwang)
|
||
Updated•8 years ago
|
Attachment #8713342 -
Flags: review?(jwwang) → review+
|
||
Updated•8 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/633d74f817b253cc9b424de664bfa23911fa8c03 Bug 1243878 - Null check CDMProxy::mKeys in CDMProxy::OnExpirationChange() before use. r=jwwang
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/633d74f817b2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•