Closed Bug 1243881 Opened 4 years ago Closed 4 years ago

Consider unshipping translateTime

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox45 + fixed
firefox46 + fixed
firefox47 + fixed

People

(Reporter: bzbarsky, Assigned: baku)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(2 files)

[Tracking Requested - why for this release]: Working group can't make up its mind, and we may not want to ship an API they've decided shouldn't exist after all.

See https://github.com/w3c/hr-time/issues/22#issuecomment-176404544 -- the webperf working group can't make up its mind, again.

I think we have a few options:

1)  Back out bug 1169068 and the changes to not use the parent's timebase for
    dedicated workers until this working group gets its act together and decides
    something else.  Note that we're talking about changes on beta at this
    point.
2)  Just go ahead and ship, and then either remove later or just leave in or
    something.

I think option 1 is the best if we don't think the risk is too high for beta...  Andrea, thoughts?

Also, I think we should stop implementing stuff this working group suggests until it's in some equivalent of CR, because they have demonstrated several times now that they don't really care about past consensus and will just randomly change stuff.
Flags: needinfo?(amarchesini)
It's early in beta, so I think #1 is the way forward.

I would definitely support a strongly worded letter (TM) to this working group that we consider their specs too unstable to implement.
I've only followed the discussion in [1]. That discussion is certainly indicating that we should unship by doing #1. I'm not sure if there are other discussions elsewhere though.

[1] https://github.com/w3c/hr-time/issues/22
Andrea, let me know if you don't have time for this and I'll pick it up, I guess.
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attached patch time.patchSplinter Review
Attachment #8713543 - Flags: review?(bzbarsky)
Comment on attachment 8713543 [details] [diff] [review]
time.patch

No, this isn't enough.  We also need to change the timebase to the parent one for dedicated workers, because otherwise people won't be able to map times...
Attachment #8713543 - Flags: review?(bzbarsky) → review-
Attached patch time2.patchSplinter Review
Consider this second patch too.
Attachment #8714260 - Flags: review?(bzbarsky)
Comment on attachment 8714260 [details] [diff] [review]
time2.patch

r=me
Attachment #8714260 - Flags: review?(bzbarsky) → review+
Comment on attachment 8713543 [details] [diff] [review]
time.patch

r=me given the other patch
Attachment #8713543 - Flags: review- → review+
Note that once this sticks we'll need to uplift to Aurora and Beta...
Comment on attachment 8713543 [details] [diff] [review]
time.patch

Approval Request Comment
[Feature/regressing bug #]: Implement the latest time performance spec
[User impact if declined]: the working group is still changing the spec and we don't want to ship something that is not stable enough from a spec point of view.
[Describe test coverage new/current, TreeHerder]: mochitests
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8713543 - Flags: approval-mozilla-beta?
Attachment #8713543 - Flags: approval-mozilla-aurora?
Comment on attachment 8714260 [details] [diff] [review]
time2.patch

See previous comment.
Attachment #8714260 - Flags: approval-mozilla-beta?
Attachment #8714260 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/52792f2aac93
https://hg.mozilla.org/mozilla-central/rev/b9dba72f9e97
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Keywords: site-compat
Comment on attachment 8713543 [details] [diff] [review]
time.patch

Make perfect sense, taking it. Should be in 45 beta 3.
Attachment #8713543 - Flags: approval-mozilla-beta?
Attachment #8713543 - Flags: approval-mozilla-beta+
Attachment #8713543 - Flags: approval-mozilla-aurora?
Attachment #8713543 - Flags: approval-mozilla-aurora+
Attachment #8714260 - Flags: approval-mozilla-beta?
Attachment #8714260 - Flags: approval-mozilla-beta+
Attachment #8714260 - Flags: approval-mozilla-aurora?
Attachment #8714260 - Flags: approval-mozilla-aurora+
I removed the mention that was in Firefox 45 for devs too.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.