Environmental markers on requirements

RESOLVED FIXED

Status

Socorro
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
At the moment we have two requirements files. One called `requirements.txt` and one `linux-requirements.txt`. 

It is possible to define your requirements, with hashes, so that they install (by pip) conditionally. This file::

   pyinotify==0.9.6 ; sys_platform == 'linux' \
    --hash=sha256:9c998a5d7606ca835065cdabc013ae6c66eb9ea76a00a1e3bc6e0cfe2b4f71f4 \
html2text==2016.1.8 \
    --hash=sha256:088046f9b126761ff7e3380064d4792279766abaa5722d0dd765d011cf0bb079
bgg==0.22.1 \
    --hash=sha256:e5172c3fda0e8a42d1797fd1ff75245c3953d7c8574089a41a219204dbaad83d \
    --hash=sha256:aaa53aea1cecb8a6e1288d6bfe52a51408a264a97d5c865c38b34ae16c9bff88

I created and ran successfully on both OSX and on Linux.
(Assignee)

Comment 1

2 years ago
Created attachment 8714354 [details] [review]
Link to Github pull-request: https://github.com/mozilla/socorro/pull/3180
(Assignee)

Comment 2

2 years ago
Hmmm... That doesn't work in Travis. 
https://twitter.com/peterbe/status/694213591390646272

Comment 3

2 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/ed6181f6473f346431ad457bb0e3baaf7c295330
fixes bug 1243898 - Environmental markers on requirements

https://github.com/mozilla/socorro/commit/0306fd74a311f547ec2e29d5e3543e62edd24e36
Merge pull request #3180 from peterbe/bug-1243898-environmental-markers-on-requirements

fixes bug 1243898 - Environmental markers on requirements

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.