1243949 - Failure to create a bloat log in a debug build should turn the tree orange

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

As seen in bug 1219369, we aren't getting bloat logs for content processes on Windows mozilla-central. This means we aren't detecting leaks at all for these processes, without any indication of it on TreeHerder. The tree should turn orange if that happens. We should MOZ_ASSERT or something if InitLog fails. This could probably just be landed as part of bug 1219369, but I'll leave a separate bug for now.

I think we do reconcile the pidlog against the processes we got a bloatlog from, so normally this would cause the tree to go orange, but I think we fail to write to the pidlog from the child process, for the same reason as bug 1219369. I'll file a separate bug for that.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Fatally assert when we fail to create an XPCOM log.

try run showing that this detects the failure to create a leak log on Windows:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=b76f140aaeb3

I'll look into this more once the Windows logging issue is fixed.

Comment 2

[Andrew McCreight [:mccr8]]

Bug 1242119 is needed for logs on WinXP.

Linux 64 and Win7 try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9261891222c5
WinXP and Win8 try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9261891222c5

I should also grep through some logs for other platforms to see if they are failing to create logs.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Fatally assert when we fail to create an XPCOM log.

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 8715320 [details] [diff] [review]
Fatally assert when we fail to create an XPCOM log.

Oops, I already uploaded this patch.

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 8714577 [details] [diff] [review]
Fatally assert when we fail to create an XPCOM log.

Review of attachment 8714577 [details] [diff] [review]:
-----------------------------------------------------------------

WinXP, Win7 and Linux64 look fine based on my try pushes. OSX seems fine from scanning a few logs. Android doesn't do leak checking at all (!?!?). B2G at least tries to, but I didn't see any evidence that it actually even attempts to create a bloat log, so hopefully that is okay.

(This depends on a bunch of patches in the bugs it depends on to get leak logging working on Windows.)

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8714577 [details] [diff] [review]
Fatally assert when we fail to create an XPCOM log.

Review of attachment 8714577 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/base/nsTraceRefcnt.cpp
@@ +705,5 @@
>                  aEnvVar, aMsg, fname.get());
>        } else {
>          fprintf(stdout, "### %s defined -- unable to log %s to %s\n",
>                  aEnvVar, aMsg, fname.get());
> +        MOZ_ASSERT(false, "Tried and failed to create an XPCOM log");

This could optionally be MOZ_CRASH("Tried and failed...");

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e94a21686360

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e94a21686360