1243950 - MOZ_PROCESS_LOG is not properly written to for Windows content processes on mozilla-central

Status: RESOLVED DUPLICATE of bug 1193861

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

In bug 1219369, I found that we weren't creating a bloat log on Windows. I thought this was weird, because we actually check that every process in the MOZ_PROCESS_LOG has a bloat log, if appropriate. It turns out that as far as I can see from looking at a mochitest log, a content process on Windows m-c (but not Linux m-c or Windows Aurora) fails to write to MOZ_PROCESS_LOG, presumably for the same reason (like sandboxing) as bug 1219369.

Two things need to happen:

1) This file opening or whatever needs to be fixed so that it works in Windows content processes.

2) EnvironmentLog::print() needs to MOZ_ASSERT or otherwise error out if it fails to create the file, so that we will notice this issue in debug builds.

Comment 1

[Andrew McCreight [:mccr8]]

Bob, is this something you could look into?

Comment 2

[Andrew McCreight [:mccr8]]

Failing to write to the process log is bad for reasons beyond leak checking. I think the test harness uses it to do things like detect and kill zombie processes, so there could be weird Mochitest failures on Windows being caused by this.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

I looked into this in bug 1193861 and even have a patch there, but ultimately decided to use psutil to manage child processes from the harness (for bug 1143547).

This doesn't work on OS X either (bug 950401).

Comment 4

[Andrew McCreight [:mccr8]]

Great.