Closed
Bug 1243959
Opened 8 years ago
Closed 8 years ago
[e10s] Enable browser_webconsole_autocomplete_in_debugger_stackframe.js in e10s
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(e10s+, firefox46 fixed, firefox47 fixed)
RESOLVED
FIXED
Firefox 47
People
(Reporter: linclark, Assigned: bgrins)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
Updated•8 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33539/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33539/
Attachment #8715591 -
Flags: review?(lclark)
Reporter | ||
Updated•8 years ago
|
Attachment #8715591 -
Flags: review?(lclark) → review+
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8715591 [details] MozReview Request: Bug 1243959 - e10s fixes for browser_webconsole_autocomplete_in_debugger_stackframe.js;r=linclark https://reviewboard.mozilla.org/r/33539/#review30365 Other than the minor question, this looks good to me! ::: devtools/client/webconsole/test/browser_webconsole_autocomplete_in_debugger_stackframe.js:21 (Diff revision 1) > + gStackframes = null; Is this something that should be handled in a cleanup function (so that it gets done even if the test errors out)?
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Lin Clark [:linclark] from comment #2) > Comment on attachment 8715591 [details] > MozReview Request: Bug 1243959 - e10s fixes for > browser_webconsole_autocomplete_in_debugger_stackframe.js;r=linclark > > https://reviewboard.mozilla.org/r/33539/#review30365 > > Other than the minor question, this looks good to me! > > ::: > devtools/client/webconsole/test/ > browser_webconsole_autocomplete_in_debugger_stackframe.js:21 > (Diff revision 1) > > + gStackframes = null; > > Is this something that should be handled in a cleanup function (so that it > gets done even if the test errors out)? Yeah I've updated it, thanks
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bf9999a917d4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment 6•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/7618fd997347
status-firefox46:
--- → fixed
Comment 7•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•