[e10s] Enable browser_webconsole_autocomplete_in_debugger_stackframe.js in e10s

RESOLVED FIXED in Firefox 46

Status

RESOLVED FIXED
3 years ago
5 months ago

People

(Reporter: linclark, Assigned: bgrins)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 47
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox46 fixed, firefox47 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

3 years ago
Blocks: 1112599
(Reporter)

Updated

3 years ago
No longer blocks: 1112599
(Reporter)

Updated

3 years ago
Blocks: 1112599

Updated

3 years ago
Blocks: 984139
tracking-e10s: --- → +
(Assignee)

Updated

3 years ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8715591 [details]
MozReview Request: Bug 1243959 - e10s fixes for browser_webconsole_autocomplete_in_debugger_stackframe.js;r=linclark

Review commit: https://reviewboard.mozilla.org/r/33539/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33539/
Attachment #8715591 - Flags: review?(lclark)
(Reporter)

Updated

3 years ago
Attachment #8715591 - Flags: review?(lclark) → review+
(Reporter)

Comment 2

3 years ago
Comment on attachment 8715591 [details]
MozReview Request: Bug 1243959 - e10s fixes for browser_webconsole_autocomplete_in_debugger_stackframe.js;r=linclark

https://reviewboard.mozilla.org/r/33539/#review30365

Other than the minor question, this looks good to me!

::: devtools/client/webconsole/test/browser_webconsole_autocomplete_in_debugger_stackframe.js:21
(Diff revision 1)
> +  gStackframes = null;

Is this something that should be handled in a cleanup function (so that it gets done even if the test errors out)?
(Assignee)

Comment 3

3 years ago
(In reply to Lin Clark [:linclark] from comment #2)
> Comment on attachment 8715591 [details]
> MozReview Request: Bug 1243959 - e10s fixes for
> browser_webconsole_autocomplete_in_debugger_stackframe.js;r=linclark
> 
> https://reviewboard.mozilla.org/r/33539/#review30365
> 
> Other than the minor question, this looks good to me!
> 
> :::
> devtools/client/webconsole/test/
> browser_webconsole_autocomplete_in_debugger_stackframe.js:21
> (Diff revision 1)
> > +  gStackframes = null;
> 
> Is this something that should be handled in a cleanup function (so that it
> gets done even if the test errors out)?

Yeah I've updated it, thanks

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bf9999a917d4
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47

Comment 6

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/7618fd997347
status-firefox46: --- → fixed

Comment 7

3 years ago
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected

Updated

5 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.